From c37549f18e326eb19d361a7a0277b40266f8792d Mon Sep 17 00:00:00 2001 From: David Date: Thu, 24 Aug 2023 09:51:17 +0700 Subject: [PATCH] [#510] Update keychainName default value with "{PROJECT_NAME}" to be replaced when run make.sh Update make.sh to accept minimum-version --- fastlane/Constants/Constant.swift | 2 +- make.sh | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fastlane/Constants/Constant.swift b/fastlane/Constants/Constant.swift index ae8ddf83..a5f96dfd 100644 --- a/fastlane/Constants/Constant.swift +++ b/fastlane/Constants/Constant.swift @@ -26,7 +26,7 @@ enum Constant { static let appleStagingTeamId = "<#teamId#>" static let appleProductionUserName = "<#userName#>" static let appleProductionTeamId = "<#teamId#>" - static let keychainName = "github_action_keychain" + static let keychainName = "{PROJECT_NAME}" static let matchURL = "git@github.com:{organization}/{repo}.git" // MARK: - Path diff --git a/make.sh b/make.sh index b8002381..61a83ee0 100644 --- a/make.sh +++ b/make.sh @@ -17,13 +17,14 @@ usage() { fi cat << EOF -Usage: $PROGNAME --bundle-id [BUNDLE_ID_PRODUCTION] --bundle-id-staging [BUNDLE_ID_STAGING] --project-name [PROJECT_NAME] +Usage: $PROGNAME --bundle-id [BUNDLE_ID_PRODUCTION] --bundle-id-staging [BUNDLE_ID_STAGING] --project-name [PROJECT_NAME] --minimum-version [MINIMUM_VERSION] --interface [INTERFACE] Set up an iOS app from tuist template. Options: -h, --help display this usage message and exit -b, --bundle-id [BUNDLE_ID_PRODUCTION] the production id (i.e. com.example.package) -s, --bundle-id-staging [BUNDLE_ID_STAGING] the staging id (i.e. com.example.package.staging) -n, --project-name [PROJECT_NAME] the project name (i.e. MyApp) +-m, --minimum-version [MINIMUM_VERSION] the minimum version of the project (i.e. 14.0) -i, --interface [INTERFACE] the user interface frameword (SwiftUI or UIKit) EOF exit 1 @@ -52,6 +53,10 @@ while [ $# -gt 0 ] ; do project_name="$2" shift ;; + -m|--minimum-version) + minimum_version="$2" + shift + ;; -i|--interface) interface="$2" shift