Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config-changes only captures diff for matching knative/serving versions #2

Open
nimakaviani opened this issue Sep 30, 2019 · 0 comments
Open

config-changes only captures diff for matching knative/serving versions #2

nimakaviani opened this issue Sep 30, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nimakaviani
Copy link
Owner

config-changes uses the data structure in https://github.com/knative/serving to determine difference between the defaults and what is changed in the kubernetes cluster.

However if there is a version discrepancy between the version of serving deployed on the cluster and the version of serving used in knative-inspect the differences are not caught by the tool.

ideally we want the diff to operate on raw data rather than the structured data.
@nimakaviani nimakaviani added enhancement New feature or request good first issue Good for newcomers labels Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nimakaviani