Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for go_proto_link visibility attribute in Gazelle plugin #13

Open
idlebot opened this issue Jul 18, 2023 · 1 comment
Open

Support for go_proto_link visibility attribute in Gazelle plugin #13

idlebot opened this issue Jul 18, 2023 · 1 comment

Comments

@idlebot
Copy link

idlebot commented Jul 18, 2023 •
edited
Loading

In order for my rule_runner to work (see issue #12), I have to manually add a visibility = ["//visibility:public"], attribute to all go_proto_link.

It would be nice if the Gazelle plugin had the option to emit the visibility attribute.

I'd be happy to submit a pull request for this issue and #12 as well.
@nikunjy
Copy link
Owner

nikunjy commented Nov 16, 2023

Sorry I haven't really looked at this repo in a while. @idlebot if you feel like submitting a PR i would be happy to accept it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idlebot @nikunjy