Upstreaming status #1
Assignees
Comments
|
Maybe I can leave some additional comments here, besides the ever growing list of patches in the first comment. The upstreaming is a complex process, not only due to the fact that the original LBSE downstream implementation needs to be split into small atomic pieces, reviewed and landed individually, but also due to the requirement of being able to switch between the old and new SVG engine at runtime. The original LBSE implementation was a replacement of WebKits SVG engine, now we have to bootstrap LBSE in parallel to the legacy SVG engine, which is complicating things and required additional R&D iterations to find a sane design that: Stay tuned. |
nikolaszimmermann
pushed a commit
that referenced
this issue
Mar 7, 2022
…ed underneath -[UIWindow dealloc] https://bugs.webkit.org/show_bug.cgi?id=237505 rdar://85563958 Reviewed by Tim Horton. Source/WebKit: It's currently possible for the web page to get permanently stuck in frozen state, due to the `BackgroundApplication` layer tree freeze reason; this occurs when the web view is unparented from the view hierarchy underneath the scope of UIWindow's `-dealloc` method. During `-[UIWindow dealloc]`, the backpointer underlying the implementation of `-[UIView window]` is set to `nil` immediately before the subclassing method hook `-willMoveToWindow:` is invoked on the view hierarchy. This means that when `-willMoveToWindow:` is invoked, `self.window` will return `nil`. This, in turn, puts `WKApplicationStateTrackingView` in a bad state because we bail early before resetting `_applicationStateTracker` in the early return below, since we (erroneously) believe that we've already been unparented from the view hierarchy, so we don't need to do anything. ``` if (!self._contentView.window || newWindow) return; ``` As a result, if the same web view is eventually moved back into another visible window, `-didMoveToWindow` bails before setting up the `_applicationStateTracker` again, since it already exists from when the previous window was still active. This means `-_applicationWillEnterForeground` is never called when the web view is reintroduced to the view hierarchy, so `LayerTreeFreezeReason::BackgroundApplication` is never lifted. To address this, we simply remove the debug assertion for `_applicationStateTracker`, and instead check whether the application state tracker exists or not for the logic of the early return. Doing so also makes the early return in `-willMoveToWindow:` consistent with the logic in one in `-didMoveToWindow`, which already consults `_applicationStateTracker`: ``` - (void)didMoveToWindow { if (!self._contentView.window || _applicationStateTracker) return; ``` Test: ApplicationStateTracking.WindowDeallocDoesNotPermanentlyFreezeLayerTree * UIProcess/ios/WKApplicationStateTrackingView.mm: (-[WKApplicationStateTrackingView willMoveToWindow:]): See above. Tools: Add an API test to exercise the bug. This API test is comprised of the following series of steps: 1. Create the web view and add it under window #1. 2. Post a "did enter background" notification. 3. Deallocate window #1 (thereby unparenting the web view in the process). 4. Post a "will enter foreground" notification. 5. Add the web view under window #2. 6. Load some HTML content and wait for a presentation update. Before the fix, this test times out because the layer tree is permanently frozen after step (3), due to the `BackgroundApplication` reason, so the presentation update in step (6) never finishes. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/ios/ApplicationStateTracking.mm: Added. (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/248106@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nikolaszimmermann
pushed a commit
that referenced
this issue
Mar 9, 2022
https://bugs.webkit.org/show_bug.cgi?id=237630 rdar://88690874 Reviewed by Jer Noble. Source/WebCore: Data cues have a start time but not an explicit duration, a data cue ends when the next data cue from the same track starts. This means we don’t know the duration of cue #1 until cue #2 is delivered, so when cue #1 is delivered it is given the end time of the media file’s duration and the actual end time is updated when cue #2 arrives. http://webkit.org/b/229924 refactored text, audio, and video tracks to not depend on HTMLMediaElement. Because InbandDataTextTrack could no longer access the HTMLMediaElement to get its duration, a duration property was added to TextTrackList that InbandDataTextTrack uses to set the duration of temporary cues. TextTrackList.duration is set when it is created and updated when the media player reports a duration change. This means that if the media file’s duration is not known when the text track list is created, and the file's duration never changes, the text track list never has a valid duration and data cues were not added to the temporary list. Fix this by updating TextTrackList.duration when a HTMLMediaElement reaches HAVE_METADATA. Test: http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::durationChanged): Update m_textTracks.duration and post the 'durationchange' event. (WebCore::HTMLMediaElement::setReadyState): Call durationChanged. (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Ditto. * html/HTMLMediaElement.h: * html/track/InbandDataTextTrack.cpp: (WebCore::InbandDataTextTrack::addDataCue): Add cues to the incomplete cue map even if the track list doesn't have duration. LayoutTests: * http/tests/media/hls/track-in-band-hls-metadata-cue-duration-expected.txt: Added. * http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html: Added. Canonical link: https://commits.webkit.org/248203@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nikolaszimmermann
pushed a commit
that referenced
this issue
Apr 20, 2022
…with-relative-parent.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=239101 <rdar://problem/91603539> Reviewed by Antti Koivisto. Source/WebCore: 1. Out of flow boxes are laid out independently from each other as the last step of their containing block layout. 2. However their static positions are computed during regular in-flow layout (as if their positions were static). In order to do #1, we maintain a ListHashSet for the out-of-flow boxes and insert them at #2 (and we also have a corresponding HashMap<ContainingBlock, ListHasSet>). Normally this is a very simple list of descendant positioned boxes and since out-of-flow boxes don't interact with each other, their position in the list is not important. e.g. <div id=A style="position: relative"> <div> <div id=B style="position: absolute"></div> <div id=C style="position: absolute"></div> </div> </div> At in-flow layout (#2), we insert B and C to "ListHashSet of A" as we come across them in DOM order and compute their static positions. Later in the layout flow when we get to the "let's layout the out-of-flow boxes" phase (#1) we simply walk the ListHashSet and lay out B and C (but "C and B" order would also work just fine). However the ICB (RenderView) is a special containing block as it can hold different types of out-of-flow boxes (absolute and fixed) and those out-of-flow boxes may have layout dependencies. e.g. <body><div id=A class=absolute><div id=B class=fixed></div></div></body> ICB's ListHasSet has both A and B, but in this case there's (static)layout dependency between these boxes. In order to figure out the static position of B, we have to have A laid out first. In order to lay out A before B, B has to be preceded by A in ICB's ListHasSet. Now full layout always guarantees the correct order. However in case of partial layout since we don't run a full #2, the ListHasSet may end up having an unexpected order. e.g. <body><div id=A class=absolute><div id=B><div id=C class=fixed></div></div></div></body> 1. The initial (full) layout produces the following (correct) order for the ICB's ListHasSet -> AC. 2. A subsequent partial layout (e.g. triggered by A's position change) runs an in-flow layout on the <body> which (re-)appends A to the ListHasSet (CA <- incorrect order). Now at this point we assume that the in-flow layout picks up B which eventually (re-)appends C to the ListHashSet (AC <- correct order). However since B does not need layout, we just stop at <body> which leaves us with an unexpected ListHashSet. 3. As part of the ICB's out-of-flow layout, we pick C as the first box to lay out followed by A. However since C's static position depends on A's position, we end up using stale geometry when computing C's static position. This patch fixes this issue by ensuring the absolute positioned boxes always come first in the ICB's ListHasSet (note that their order is not really important -see above. What's important is that a potential (as-if-static) containing block always comes before the fixed boxes). Test: fast/block/fixed-inside-absolute-positioned.html * rendering/RenderBlock.cpp: (WebCore::PositionedDescendantsMap::addDescendant): (WebCore::RenderBlock::insertPositionedObject): LayoutTests: * fast/block/fixed-inside-absolute-positioned-expected.html: Added. * fast/block/fixed-inside-absolute-positioned.html: Added. * platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/249597@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nikolaszimmermann
pushed a commit
that referenced
this issue
Apr 20, 2022
…with-relative-parent.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=239101 <rdar://problem/91603539> Reviewed by Antti Koivisto. Source/WebCore: 1. Out of flow boxes are laid out independently from each other as the last step of their containing block layout. 2. However their static positions are computed during regular in-flow layout (as if their positions were static). In order to do #1, we maintain a ListHashSet for the out-of-flow boxes and insert them at #2 (and we also have a corresponding HashMap<ContainingBlock, ListHasSet>). Normally this is a very simple list of descendant positioned boxes and since out-of-flow boxes don't interact with each other, their position in the list is not important. e.g. <div id=A style="position: relative"> <div> <div id=B style="position: absolute"></div> <div id=C style="position: absolute"></div> </div> </div> At in-flow layout (#2), we insert B and C to "ListHashSet of A" as we come across them in DOM order and compute their static positions. Later in the layout flow when we get to the "let's layout the out-of-flow boxes" phase (#1) we simply walk the ListHashSet and lay out B and C (but "C and B" order would also work just fine). However the ICB (RenderView) is a special containing block as it can hold different types of out-of-flow boxes (absolute and fixed) and those out-of-flow boxes may have layout dependencies. e.g. <body><div id=A class=absolute><div id=B class=fixed></div></div></body> ICB's ListHasSet has both A and B, but in this case there's (static)layout dependency between these boxes. In order to figure out the static position of B, we have to have A laid out first. In order to lay out A before B, B has to be preceded by A in ICB's ListHasSet. Now full layout always guarantees the correct order. However in case of partial layout since we don't run a full #2, the ListHasSet may end up having an unexpected order. e.g. <body><div id=A class=absolute><div id=B><div id=C class=fixed></div></div></div></body> 1. The initial (full) layout produces the following (correct) order for the ICB's ListHasSet -> AC. 2. A subsequent partial layout (e.g. triggered by A's position change) runs an in-flow layout on the <body> which (re-)appends A to the ListHasSet (CA <- incorrect order). Now at this point we assume that the in-flow layout picks up B which eventually (re-)appends C to the ListHashSet (AC <- correct order). However since B does not need layout, we just stop at <body> which leaves us with an unexpected ListHashSet. 3. As part of the ICB's out-of-flow layout, we pick C as the first box to lay out followed by A. However since C's static position depends on A's position, we end up using stale geometry when computing C's static position. This patch fixes this issue by ensuring the absolute positioned boxes always come first in the ICB's ListHasSet (note that their order is not really important -see above. What's important is that a potential (as-if-static) containing block always comes before the fixed boxes). Test: fast/block/fixed-inside-absolute-positioned.html * rendering/RenderBlock.cpp: (WebCore::PositionedDescendantsMap::addDescendant): (WebCore::RenderBlock::insertPositionedObject): LayoutTests: * fast/block/fixed-inside-absolute-positioned-expected.html: Added. * fast/block/fixed-inside-absolute-positioned.html: Added. * platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/249626@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LBSE upstreaming status
- last update: 2024-03-05-
Overall status: 87%
Organization
The bug report "Harmonize HTML & SVG rendering" is the master bug report for the layer based SVG engine.
The goal is to upstream the work in such a way that one can dynamically change from legacy to layer engine, and vise-versa at runtime. In the following the individual patches that were upstreamed are listed. This issue is updated whenever a new patch landed upstream.
Upstreamed patches
2021-11-29 - [LBSE] Add runtime flag for Layer-based SVG engine (LBSE)Tag in this repository: upstreaming_patch1_v3
Ticket: https://bugs.webkit.org/show_bug.cgi?id=233211
Status: Committed https://trac.webkit.org/changeset/286204/webkit (12.9 KB patch, reviewed by Sam Weinig)
2021-12-01 - [LBSE] Rename RenderSVGRoot -> LegacyRenderSVGRootTag in this repository: upstreaming_patch2_v4
Ticket: https://bugs.webkit.org/show_bug.cgi?id=233666
Status: Committed https://trac.webkit.org/changeset/286392/webkit (111.53 KB patch, reviewed by Rob Buis)
2021-12-06 - [LBSE] Add RenderObject::isSVGRootOrLegacySVGRoot() helperTag in this repository: upstreaming_patch3_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=233870
Status: Committed https://trac.webkit.org/changeset/286542/webkit (17.59 KB patch, reviewed by Rob Buis)
2021-12-06 - [LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effectTag in this repository: upstreaming_patch4_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=233871
Status: Committed https://trac.webkit.org/changeset/286543/webkit (4.21 KB patch, reviewed by Rob Buis)
2021-12-10 - [LBSE] Begin layer-aware RenderSVGRoot implementationTag in this repository: upstreaming_patch5_v7
Ticket: https://bugs.webkit.org/show_bug.cgi?id=233863
Status: Committed https://trac.webkit.org/changeset/286842/webkit (46.44 KB patch, reviewed by Rob Buis)
2021-12-10 - [LBSE] Handle RenderSVGRoot in all places that handle LegacyRenderSVGRootTag in this repository: upstreaming_patch6_v3
Ticket: https://bugs.webkit.org/show_bug.cgi?id=233872
Status: Committed https://trac.webkit.org/changeset/286843/webkit (21.27 KB patch, reviewed by Rob Buis)
2021-12-10 - [LBSE] Create RenderSVGRoot renderer for outermost and allow direct childrenTag in this repository: upstreaming_patch7_v3
Ticket: https://bugs.webkit.org/show_bug.cgi?id=233873
Status: Committed https://trac.webkit.org/changeset/286846/webkit (7.99 KB patch, reviewed by Rob Buis)
2021-12-13 - [LBSE] Rename RenderSVGModelObject -> LegacyRenderSVGModelObjectTag in this repository: upstreaming_patch8_v3
Ticket: https://bugs.webkit.org/show_bug.cgi?id=234235
Status: Committed https://trac.webkit.org/changeset/286962/webkit (50.16 KB patch, reviewed by Rob Buis)
2022-01-03 - [LBSE] Begin layer-aware RenderSVGModelObject implementationTag in this repository: upstreaming_patch9_v8
Ticket: https://bugs.webkit.org/show_bug.cgi?id=234524
Status: Committed https://trac.webkit.org/changeset/287538/webkit (37.97 KB patch, reviewed by Rob Buis)
2022-01-06 - [LBSE] Rename RenderSVGShape -> LegacyRenderSVGShapeTag in this repository: upstreaming_patch10_v1
Ticket: https://bugs.webkit.org/show_bug.cgi?id=234877
Status: Committed https://trac.webkit.org/changeset/287677/webkit (112.32 KB patch, reviewed by Rob Buis)
2022-01-07 - [LBSE] Rename RenderSVGRect -> LegacyRenderSVGRectTag in this repository: upstreaming_patch11_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=234878
Status: Committed https://trac.webkit.org/changeset/287743/webkit (27.72 KB patch, reviewed by Rob Buis)
2022-01-10 - [LBSE] Begin layer-aware RenderSVGShape implementationTag in this repository: upstreaming_patch12_v5
Ticket: https://bugs.webkit.org/show_bug.cgi?id=234954
Status: Committed https://trac.webkit.org/changeset/287832/webkit (74.62 KB patch, reviewed by Rob Buis)
2022-01-10 - [LBSE] Begin layer-aware RenderSVGRect implementationTag in this repository: upstreaming_patch13_v3
Ticket: https://bugs.webkit.org/show_bug.cgi?id=234992
Status: Committed https://trac.webkit.org/changeset/287834/webkit (19.76 KB patch, reviewed by Rob Buis)
2022-01-11 - [LBSE] Introduce SVGBoundingBoxComputationTag in this repository: upstreaming_patch14_v3
Ticket: https://bugs.webkit.org/show_bug.cgi?id=234632
Status: Committed https://trac.webkit.org/changeset/287873/webkit (34.24 KB patch, reviewed by Rob Buis)
2022-01-12 - [LBSE] Rename RenderSVGContainer -> LegacyRenderSVGContainerTag in this repository: upstreaming_patch15_v1
Ticket: https://bugs.webkit.org/show_bug.cgi?id=235099
Status: Committed https://trac.webkit.org/changeset/287916/webkit (54.68 KB patch, reviewed by Rob Buis)
2022-01-12 - [LBSE] Begin layer-aware RenderSVGContainer implementationTag in this repository: upstreaming_patch16_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=235100
Status: Committed https://trac.webkit.org/changeset/287921/webkit (33.99 KB patch, reviewed by Rob Buis)
2022-01-14 - [LBSE] Introduce SVGContainerLayoutTag in this repository: upstreaming_patch17_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=235101
Status: Committed https://trac.webkit.org/changeset/288011/webkit (25.77 KB patch, reviewed by Rob Buis)
2022-02-05 - [LBSE] Handle RenderSVGShape in SVGRenderSupport::applyStrokeStyleToContext()Tag in this repository: upstreaming_patch18_v1
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236077
Status: Committed https://trac.webkit.org/changeset/289163/webkit (2.27 KB patch, reviewed by Darin Adler)
2022-02-05 - [LBSE] Introduce RenderSVGModelObject aware geometry accessors in RenderLayerBackingTag in this repository: upstreaming_patch19_v1
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236184
Status: Committed https://trac.webkit.org/changeset/289213/webkit (10.21 KB patch, reviewed by Rob Buis)
2022-02-05 - [LBSE] Begin stub implementation of transform support for SVG layersTag in this repository: upstreaming_patch20_v5
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236185
Status: Committed https://trac.webkit.org/changeset/289606/webkit (21.04 KB patch, reviewed by Rob Buis)
2022-02-05 - [LBSE] Generalize RenderLayer::renderBoxLocation(), adding support for SVG layersTag in this repository: upstreaming_patch21_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236186
Status: Committed https://trac.webkit.org/changeset/289210/webkit (22.17 KB patch, reviewed by Rob Buis)
2022-02-05 - [LBSE] Apply position / size to SVG layersTag in this repository: upstreaming_patch22_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236187
Status: Committed https://trac.webkit.org/changeset/289207/webkit (4.73 KB patch, reviewed by Rob Buis)
2022-02-05 - [LBSE] Extend overflow/clip rect handling for SVG layersTag in this repository: upstreaming_patch23_v1
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236188
Status: Committed https://trac.webkit.org/changeset/289204/webkit (7.08 KB patch, reviewed by Rob Buis)
2022-02-05 - [LBSE] Suppress non-foreground paint phases for SVG shapes & imagesTag in this repository: upstreaming_patch24_v3
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236189
Status: Committed https://trac.webkit.org/changeset/289205/webkit (3.35 KB patch, reviewed by Rob Buis)
2022-02-05 - [LBSE] Include hidden SVG layers in the z-order lists for hit testing purposes
Tag in this repository: upstreaming_patch25_v1
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236190
Status: Pending review
2022-02-05 - [LBSE] Apply SVG specific changes to RenderLayer paintingTag in this repository: upstreaming_patch26_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236191
Status: Committed https://trac.webkit.org/changeset/290008/webkit (5.18 KB patch, reviewed by Rob Buis)
2022-02-06 - RenderLayer: Simplify RenderElement::paint() callsTag in this repository: upstreaming_patch27_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236192
Status: Committed https://trac.webkit.org/changeset/289360/webkit (7.25 KB patch, reviewed by Simon Fraser)
2022-02-06 - [LBSE] Implement SVG2 rules to establish a stacking contextTag in this repository: upstreaming_patch28_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236193
Status: Committed https://trac.webkit.org/changeset/290254/webkit (5.31 KB patch, reviewed by Rob Buis)
2022-02-06 - [LBSE] Activate LBSE for paintingTag in this repository: upstreaming_patch29_v1
Ticket: https://bugs.webkit.org/show_bug.cgi?id=236194
Status: Committed https://trac.webkit.org/changeset/290324/webkit (3.29 KB patch, reviewed by Rob Buis)
2022-02-22 - [LBSE] Rename RenderSVGTransformableContainer -> LegacyRenderSVGTransformableContainerTag in this repository: upstreaming_patch30_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=237023
Status: Committed https://trac.webkit.org/changeset/290326/webkit (30.48 KB patch, reviewed by Rob Buis)
2022-02-22 - [LBSE] Begin layer-aware RenderSVGTransformableContainer implementationTag in this repository: upstreaming_patch31_v3
Ticket: https://bugs.webkit.org/show_bug.cgi?id=237024
Status: Committed https://trac.webkit.org/changeset/290880/webkit (19.11 KB patch, reviewed by Rob Buis)
2022-03-04 - Add hasTransformOrPerspective() helper to RenderObjectTag in this repository: upstreaming_patch32_v1
Ticket: https://bugs.webkit.org/show_bug.cgi?id=237469
Status: Committed https://trac.webkit.org/changeset/290881/webkit (3.41 KB patch, reviewed by Darin Adler)
2022-03-07 - Cleanup RenderLayer::currentTransform()Tag in this repository: upstreaming_patch33_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=237553
Status: Committed https://trac.webkit.org/changeset/291105/webkit (16.83 KB patch, reviewed by Rob Buis)
2022-03-07 - Unify 'transform-box' reference box computationTag in this repository: upstreaming_patch34_v10
Ticket: https://bugs.webkit.org/show_bug.cgi?id=237554
Status: Committed https://trac.webkit.org/changeset/292525/webkit (27.23 KB patch, reviewed by Simon Fraser) + additional build fix in https://trac.webkit.org/changeset/292526/webkit
2022-03-08 - Extract transform-origin handling out of RenderStyle::applyTransform()Tag in this repository: upstreaming_patch35_v5
Ticket: https://bugs.webkit.org/show_bug.cgi?id=237590
Status: Committed https://trac.webkit.org/changeset/291338/webkit (9.08 KB patch, reviewed by Simon Fraser)
2022-03-10 - Unify reference box / CTM computation in RenderLayerTag in this repository: upstreaming_patch36_v10
Ticket: https://bugs.webkit.org/show_bug.cgi?id=237701
Status: Committed https://trac.webkit.org/changeset/292575/webkit (19.98 KB patch, reviewed by Rob Buis)
2022-03-10 - [LBSE] Activate SVG transform support through layersTag in this repository: upstreaming_patch37_v11
Ticket: https://bugs.webkit.org/show_bug.cgi?id=237711
Status: Committed https://trac.webkit.org/changeset/292706/webkit (25.91 KB patch, reviewed by Rob Buis)
2022-04-04 - Perspective should not be affected by transform-originTag in this repository: upstreaming_patch38_v7
Ticket: https://bugs.webkit.org/show_bug.cgi?id=211787
Status: Commited https://trac.webkit.org/changeset/294615/webkit (35.42 KB patch, reviewed by Simon Fraser)
2022-04-25 - [LBSE] Fix origin of transformations in SVGTag in this repository: upstreaming_patch39_v4
Ticket: https://bugs.webkit.org/show_bug.cgi?id=239717
Status: Committed https://trac.webkit.org/changeset/293504/webkit (48.14 KB patch, reviewed by Rob Buis)
2022-04-25 - [LBSE] Activate text rendering, by re-using RenderSVGTextTag in this repository: upstreaming_patch40_v5
Ticket: https://bugs.webkit.org/show_bug.cgi?id=239743
Status: Committed https://trac.webkit.org/changeset/294385/webkit (40.71 KB patch, reviewed by Rob Buis)
2022-04-25 - [LBSE] Run layout tests with LBSE activatedTag in this repository: upstreaming_patch41_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=239764
Status: Committed https://trac.webkit.org/changeset/294390/webkit (10.75 MB patch, reviewed by Rob Buis)
2022-04-27 - [LBSE] ENABLE_LAYER_BASED_SVG_ENGINE needs to match for iOS and macOSTag in this repository: upstreaming_patch42_v2
Ticket: https://bugs.webkit.org/show_bug.cgi?id=239877
Status: Committed https://trac.webkit.org/changeset/294389/webkit (1.87 KB patch, reviewed by Simon Fraser)
-- SWITCHED EXCLUSIVELY TO GITHUB WORKFLOW --
2022-05-23 - [LBSE] Add support for 'circle' & 'ellipse'Pull request: [LBSE] Add support for <circle> & <ellipse> WebKit/WebKit#912
Ticket: https://bugs.webkit.org/show_bug.cgi?id=240793
Status: Committed https://commits.webkit.org/250913@main (reviewed by Rob Buis)
2022-05-24 - [LBSE] Add support for 'path'Pull request: [LBSE] Add support for <path> WebKit/WebKit#973
Ticket: https://bugs.webkit.org/show_bug.cgi?id=240864
Status: Committed https://commits.webkit.org/251688@main (reviewed by Rob Buis)
2022-06-19 - [LBSE] Add 'viewBox' supportPull request: [LBSE] Add 'viewBox' support WebKit/WebKit#1623
Ticket: https://bugs.webkit.org/show_bug.cgi?id=241762
Status: Committed https://commits.webkit.org/252643@main (reviewed by Rob Buis)
2022-07-13 - macOS - add 'notifyutil -p com.apple.WebKit.showPaintOrderTree' commandPull request: macOS - add 'notifyutil -p com.apple.WebKit.showPaintOrderTree' command WebKit/WebKit#2358
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242680
Status: Committed https://commits.webkit.org/252447@main (reviewed by Simon Fraser)
2022-07-13 - [LBSE] Move the SVGLayerTransformUpdater class in its own filePull request: [LBSE] Move the SVGLayerTransformUpdater class in its own file WebKit/WebKit#2360
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242682
Status: Committed https://commits.webkit.org/252449@main (reviewed by Adrian Perez de Castro)
2022-07-13 - [LBSE] Begin stub implementation of RenderSVGViewportContainerPull request: [LBSE] Begin stub implementation of RenderSVGViewportContainer WebKit/WebKit#2371
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242701
Status: Committed https://commits.webkit.org/252500@main (reviewed by Rob Buis)
2022-07-13 - Fix typo in RenderObject 'hasTransformOrPespective' accessorPull request: Fix typo in RenderObject 'hasTransformOrPespective' accessor WebKit/WebKit#2377
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242713
Status: Committed https://commits.webkit.org/252446@main (reviewed by Manuel Rego Casasnovas)
2022-07-13 - [LBSE] Cleanup RenderSVGRoot codePull request: [LBSE] Cleanup RenderSVGRoot code WebKit/WebKit#2382
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242715
Status: Committed https://commits.webkit.org/252450@main (reviewed by Rob Buis)
2022-07-13 - [LBSE] Cleanup RenderSVGContainer related codePull request: [LBSE] Cleanup RenderSVGContainer related code WebKit/WebKit#2383
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242718
Status: Committed https://commits.webkit.org/252466@main (reviewed by Rob Buis)
2022-07-14 - [LBSE] Align SVG render tree dumps with HTML/CSSPull request: [LBSE] Align SVG render tree dumps with HTML/CSS WebKit/WebKit#2406
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242745
Status: Committed https://commits.webkit.org/252499@main (reviewed by Rob Buis)
2022-07-14 - run-webkit-tests -p svg does not finish (Python assertion)Pull request: run-webkit-tests -p svg does not finish (Python assertion) WebKit/WebKit#2446
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242763
Status: Committed https://commits.webkit.org/252498@main (reviewed by Philippe Normand)
2022-07-16 - [LBSE] Enable compositing support for SVG elementsPull request: [LBSE] Enable compositing support for SVG elements WebKit/WebKit#2487
Ticket: https://bugs.webkit.org/show_bug.cgi?id=242833
Status: Committed https://commits.webkit.org/253054@main (reviewed by Simon Fraser)
2022-08-01 - [LBSE] Add support for inner 'svg' elementsPull request: [LBSE] Add support for inner <svg> elements WebKit/WebKit#2894
Ticket: https://bugs.webkit.org/show_bug.cgi?id=243396
Status: Committed https://commits.webkit.org/253068@main (reviewed by Rob Buis)
2022-08-03 - [LBSE] Activate support for 'switch' and 'use' elementsPull request: [LBSE] Activate support for 'switch' and 'use' elements WebKit/WebKit#2973
Ticket: https://bugs.webkit.org/show_bug.cgi?id=243489
Status: Committed https://commits.webkit.org/253075@main (reviewed by Rob Buis)
2022-08-03 - [LBSE] Activate support for 'a' / 'altGlyph' / 'textPath' / 'tref' and 'tspan' elementsPull request: [LBSE] Activate support for 'a' / 'altGlyph' / 'textPath' / 'tref' and 'tspan' elements WebKit/WebKit#2977
Ticket: https://bugs.webkit.org/show_bug.cgi?id=243493
Status: Committed https://commits.webkit.org/253113@main (reviewed by Rob Buis)
2022-08-03 - [LBSE] Activate support for 'defs' (hidden containers)Pull request: [LBSE] Activate support for 'defs' (hidden containers) WebKit/WebKit#3027
Ticket: https://bugs.webkit.org/show_bug.cgi?id=243497
Status: Committed https://commits.webkit.org/253510@main (reviewed by Rob Buis)
2022-08-03 - [LBSE] Add support for 'foreignObject' elementsPull request: [LBSE] Add support for 'foreignObject' elements WebKit/WebKit#3664
Ticket: https://bugs.webkit.org/show_bug.cgi?id=243498
Status: Committed https://commits.webkit.org/253816@main (reviewed by Rob Buis)
2022-08-03 - [LBSE] Add support for 'image' elementsPull request: [LBSE] Add support for 'image' elements WebKit/WebKit#3532
Ticket: https://bugs.webkit.org/show_bug.cgi?id=243499
Status: Committed https://commits.webkit.org/253793@main (reviewed by Rob Buis)
2022-08-04 - [LBSE] Activate remaining shapes ('polyline' / 'polygon' / 'line')Pull request: [LBSE] Activate remaining shapes ('polyline' / 'polygon' / 'line') WebKit/WebKit#3019
Ticket: https://bugs.webkit.org/show_bug.cgi?id=243531
Status: Committed https://commits.webkit.org/253177@main (reviewed by Rob Buis)
2022-08-06 - [macOS] Check in remaining pixel test results to assist LBSE developmentPull request: [macOS] Check in remaining pixel test results to assist LBSE development WebKit/WebKit#3072
Ticket: https://bugs.webkit.org/show_bug.cgi?id=243623
Status: Committed https://commits.webkit.org/253240@main (reviewed by Rob Buis)
2022-08-29 - [LBSE] Text rendering is not pixel perfectPull request: [LBSE] Text rendering is not pixel perfect WebKit/WebKit#3765
Ticket: https://bugs.webkit.org/show_bug.cgi?id=244487
Status: Committed https://commits.webkit.org/253938@main (reviewed by Rob Buis)
2022-09-03 - [LBSE] Add macOS specific TestExpectations for all tests in LayoutTests/svg/Pull request: [LBSE] Extend macOS Monterey LBSE specific TestExpectations to cover all tests in LayoutTests/svg WebKit/WebKit#4000
Ticket: https://bugs.webkit.org/show_bug.cgi?id=244770
Status: Committed https://commits.webkit.org/254160@main> (reviewed by Rob Buis)
2022-09-05 - [LBSE] Fix null-pointer access in SVGGraphicsElement::didAttachRenderers()Pull request: [LBSE] Fix null-pointer access in SVGGraphicsElement::didAttachRenderers() WebKit/WebKit#4022
Ticket: https://bugs.webkit.org/show_bug.cgi?id=244798
Status: Committed https://commits.webkit.org/254161@main (reviewed by Rob Buis)
2022-09-05 - [LBSE] Finish TestExpectations update for both release/debug buildsPull request: [LBSE] Finish TestExpectations update for both release/debug builds WebKit/WebKit#4028
Ticket: https://bugs.webkit.org/show_bug.cgi?id=244805
Status: Committed https://commits.webkit.org/254168@main (reviewed by Rob Buis)
2022-09-09 - [LBSE] Not all 'outermost' <svg> elements enforce a stacking contextPull request: [LBSE] Not all 'outermost' <svg> elements enforce a stacking context WebKit/WebKit#4157
Ticket: https://bugs.webkit.org/show_bug.cgi?id=244965
Status: Committed https://commits.webkit.org/254314@main (reviewed by Rob Buis)
2022-09-09 - [LBSE] Outermost <svg> elements are not device-pixel alignedPull request: [LBSE] Outermost <svg> elements are not device-pixel aligned WebKit/WebKit#4158
Ticket: https://bugs.webkit.org/show_bug.cgi?id=244966
Status: Committed https://commits.webkit.org/254558@main (reviewed by Rob Buis)
2022-09-19 - Use dynamicDowncast() in RenderBox::offsetFromContainer()Pull request: Use dynamicDowncast() in RenderBox::offsetFromContainer() WebKit/WebKit#4482
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245362
Status: Committed https://commits.webkit.org/254644@main (reviewed by Tim Nguyen)
2022-09-19 - Cleanup RenderLayer::updateLayerPosition()Pull request: Cleanup RenderLayer::updateLayerPosition() WebKit/WebKit#4483
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245363
Status: Committed https://commits.webkit.org/256880@main (reviewed by Simon Fraser)
2022-09-19 - Cleanup / micro-optimize RenderLayers accumulateOffsetTowardsAncestor helperPull request: Cleanup / micro-optimize RenderLayers accumulateOffsetTowardsAncestor helper WebKit/WebKit#4504
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245395
Status: Committed https://commits.webkit.org/254669@main (reviewed by Rob Buis)
2022-09-19 - Cleanup RenderLayer::paintLayerByApplyingTransform()Pull request: Cleanup RenderLayer::paintLayerByApplyingTransform() WebKit/WebKit#4505
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245397
Status: Committed https://commits.webkit.org/254720@main (reviewed by Rob Buis)
2022-09-20 - [LBSE] Pixel snapping logic is incorrect for SVG, when elements are compositedPull request: [LBSE] Pixel snapping logic is incorrect for SVG, when elements are composited WebKit/WebKit#4520
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245416
Status: Committed https://commits.webkit.org/254863@main (reviewed by Rob Buis)
2022-09-20 - [LBSE] Activate sub-pixel precision for render tree dumpsPull request: [LBSE] Activate sub-pixel precision for render tree dumps WebKit/WebKit#4521
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245417
Status: Committed https://commits.webkit.org/254784@main (reviewed by Rob Buis)
2022-10-04 - Rename SVGSVGElement::currentViewportSize() -> currentViewportSizeExcludingZoom() for clarityPull request: Rename SVGSVGElement::currentViewportSize() -> currentViewportSizeExcludingZoom() for clarity WebKit/WebKit#4979
Ticket: https://bugs.webkit.org/show_bug.cgi?id=246016
Status: Committed https://commits.webkit.org/255221@main (reviewed by Alejandro G. Castro)
2022-10-04 - [LBSE] Cleanup SVGSVGElements svgAttributeChanged() / currentViewBoxRect()Pull request: [LBSE] Cleanup SVGSVGElements svgAttributeChanged() / currentViewBoxRect() WebKit/WebKit#4980
Ticket: https://bugs.webkit.org/show_bug.cgi?id=246017
Status: Committed https://commits.webkit.org/255264@main (reviewed by Alejandro G. Castro)
2022-10-04 - [LBSE] Enable size negotiation logic for <object> + RenderSVGRootPull request: [LBSE] Enable size negotiation logic for <object> + RenderSVGRoot in LBSE WebKit/WebKit#4992
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245907
Status: Committed https://commits.webkit.org/255291@main (reviewed by Adrian Perez de Castro)
2022-10-04 - [LBSE] Fix SVGImage container size propagationPull request: [LBSE] Fix SVGImage container size propagation WebKit/WebKit#4995
Ticket: https://bugs.webkit.org/show_bug.cgi?id=246034
Status: Committed https://commits.webkit.org/255625@main (reviewed by Rob Buis)
2022-10-04 - [LBSE] Unreviewed gardening -- update text baseline if neededPull request: [LBSE] Unreviewed gardening -- update text baseline if needed WebKit/WebKit#4998
Ticket: https://bugs.webkit.org/show_bug.cgi?id=246038
Status: Committed https://commits.webkit.org/255145@main (unreviewed)
2022-10-04 - [LBSE] Assure HTML descendants create a new formatting contextPull request: [LBSE] Assure <foreignObject> HTML descendants create a new formatting context WebKit/WebKit#5021Pull request: [LBSE] Assure <foreignObject> HTML descendants create a new formatting context WebKit/WebKit#6735
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245908
Status: Committed https://commits.webkit.org/255626@main (reviewed by Rob Buis)Status: Reverted https://commits.webkit.org/255793@mainStatus: Committed https://commits.webkit.org/256960@main (reviewed by Simon Fraser)
2022-09-21 - [LBSE] Fix/enable zooming & panning - improve interopPull request: [LBSE] Fix/enable zooming & panning - improve interop WebKit/WebKit#5073
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245507
Status: Committed https://commits.webkit.org/255727@main (reviewed by Rob Buis)
2022-09-21 - [LBSE] Fix transform support for SVG <text> elementsPull request: [LBSE] Fix transform support for SVG <text> elements WebKit/WebKit#5534
Ticket: https://bugs.webkit.org/show_bug.cgi?id=245508
Status: Committed https://commits.webkit.org/255801@main (reviewed by Rob Buis)
2022-11-09 - [LBSE] Provide macOS Ventura pixel baseline for LayoutTests/svgPull request: [LBSE] Provide macOS Ventura pixel baseline for LayoutTests/svg WebKit/WebKit#6290
Ticket: https://bugs.webkit.org/show_bug.cgi?id=247666
Status: Committed https://commits.webkit.org/256482@main (unreviewed)
2022-11-09 - [LBSE] Add remaining compositing tests from LBSE downstreamPull request: [LBSE] Add remaining compositing tests from LBSE downstream WebKit/WebKit#6291
Ticket: https://bugs.webkit.org/show_bug.cgi?id=247667
Status: Committed https://commits.webkit.org/256502@main (reviewed by Rob Buis)
2022-11-09 - [LBSE] Add transform related tests from LBSE downstreamPull request: [LBSE] Add transform related tests from LBSE downstream WebKit/WebKit#6292
Ticket: https://bugs.webkit.org/show_bug.cgi?id=247668
Status: Committed https://commits.webkit.org/256948@main (reviewed by Rob Buis)
2022-11-09 - [LBSE] Enforce presence of a RenderSVGViewportContainer, even if the has no childrenPull request: [LBSE] Enforce presence of a RenderSVGViewportContainer, even if the <svg> has no children WebKit/WebKit#6293
Ticket: https://bugs.webkit.org/show_bug.cgi?id=247669
Status: Committed https://commits.webkit.org/256604@main (reviewed by Rob Buis)
2022-11-09 - [LBSE] Allow to query supplementalTransform() without creationPull request: [LBSE] Allow to query supplementalTransform() without creation WebKit/WebKit#6294
Ticket: https://bugs.webkit.org/show_bug.cgi?id=247670
Status: Committed https://commits.webkit.org/256786@main (reviewed by Rob Buis)
2022-11-09 - [LBSE] Transform update handling is unreliablePull request: [LBSE] Transform update handling is unreliable WebKit/WebKit#6295
Ticket: https://bugs.webkit.org/show_bug.cgi?id=247671
Status: Committed https://commits.webkit.org/256787@main (reviewed by Rob Buis)
2022-11-09 - [LBSE] Unify all SVG geometry/transform computations with CSSPull request: [LBSE] Unify all SVG geometry/transform computations with CSS WebKit/WebKit#6297
Ticket: https://bugs.webkit.org/show_bug.cgi?id=247672
Status: Committed https://commits.webkit.org/256862@main (reviewed by Rob Buis)
2022-12-12 - Remove orphaned function definition from RenderLayerModelObjectPull request: Remove orphaned function definition from RenderLayerModelObject WebKit/WebKit#7479
Ticket: https://bugs.webkit.org/show_bug.cgi?id=249137
Status: Committed https://commits.webkit.org/257922@main (unreviewed)
2022-12-12 - Cleanup SVGContainerLayout::layoutSizeOfNearestViewportChangedPull request: Cleanup SVGContainerLayout::layoutSizeOfNearestViewportChanged WebKit/WebKit#7480
Ticket: https://bugs.webkit.org/show_bug.cgi?id=249139
Status: Committed https://commits.webkit.org/258133@main (reviewed by Rob Buis)
2022-12-12 - Fix reset to baseVal after animation end for SVGTransformListPull request: Fix reset to baseVal after animation end for SVGTransformList WebKit/WebKit#7481
Ticket: https://bugs.webkit.org/show_bug.cgi?id=249140
Status: Committed https://commits.webkit.org/268987@main (reviewed by Rob Buis)
2022-12-12 - [LBSE] Do not relayout on dynamic transform changes, if not necessaryPull request: [LBSE] Do not relayout on dynamic transform changes, if necessary. WebKit/WebKit#7482
Ticket: https://bugs.webkit.org/show_bug.cgi?id=249141
Status: Committed https://commits.webkit.org/259158@main (reviewed by Rob Buis)
2022-12-12 - [LBSE] Add new tests that cover repainting after transform changesPull request: [LBSE] Add new tests that cover repainting after transform changes WebKit/WebKit#7484
Ticket: https://bugs.webkit.org/show_bug.cgi?id=249142
Status: Committed https://commits.webkit.org/259243@main (reviewed by Rob Buis)
2023-01-18 - [LBSE] Update 'mac-ventura-wk2-pixel' pixel test baselinePull request: [LBSE] Update 'mac-ventura-wk2-pixel' pixel test baseline WebKit/WebKit#8794
Ticket: https://bugs.webkit.org/show_bug.cgi?id=250793
Status: Committed https://commits.webkit.org/259051@main (unreviewed)
2023-01-18 - [LBSE] Update 'mac-ventura-wk2-lbse-text' test baselinePull request: [LBSE] Update 'mac-ventura-wk2-lbse-text' test baseline WebKit/WebKit#8802
Ticket: https://bugs.webkit.org/show_bug.cgi?id=250804
Status: Committed https://commits.webkit.org/259060@main (unreviewed)
2023-05-30 - [LBSE] Update 'mac-ventura-wk2-pixel' test baselinePull request: [LBSE] Update 'mac-ventura-wk2-pixel' test baseline WebKit/WebKit#14480
Ticket: https://bugs.webkit.org/show_bug.cgi?id=257484
Status: Committed https://commits.webkit.org/264673@main (unreviewed)
2023-06-04 - REGRESSION: Dynamic attribute updates partly broken for SVGPull request: REGRESSION: Dynamic attribute updates partly broken for SVG WebKit/WebKit#14818
Ticket: https://bugs.webkit.org/show_bug.cgi?id=257900
Status: Committed https://commits.webkit.org/265069@main (reviewed by Rob Buis)
2023-06-14 - [LBSE] Gardening, update pixel+text resultsPull request: [LBSE] Gardening, update pixel+text results WebKit/WebKit#14948
Ticket: https://bugs.webkit.org/show_bug.cgi?id=258067
Status: Committed https://commits.webkit.org/265144@main (unreviewed)
2023-06-16 - [LBSE] Computation of on-screen font scaling factor ignores page zoomPull request: [LBSE] Computation of on-screen font scaling factor ignores page zoom WebKit/WebKit#15000
Ticket: https://bugs.webkit.org/show_bug.cgi?id=258120
Status: Committed https://commits.webkit.org/265208@main (reviewed by Rob Buis)
2023-06-16 - [LBSE] Enable accelerated transform animations for SVG renderersPull request: [LBSE] Enable accelerated transform animations for SVG renderers WebKit/WebKit#15001
Ticket: https://bugs.webkit.org/show_bug.cgi?id=258122
Status: Committed https://commits.webkit.org/268111@main (reviewed by Rob Buis)
2023-09-17 - [LBSE] Gardening, update pixel+text resultsPull request: [LBSE] Gardening, update pixel+text results WebKit/WebKit#17843
Ticket: https://bugs.webkit.org/show_bug.cgi?id=261650
Status: Committed https://commits.webkit.org/268062@main (unreviewed)
2023-09-19 - Move more SVG code into legacyPull request: Move more SVG code into legacy WebKit/WebKit#17844
Ticket: https://bugs.webkit.org/show_bug.cgi?id=261652
Status: Committed https://commits.webkit.org/268081@main (reviewed by Nikolas Zimmermann)
2023-09-20 - Move RenderSVGResourceContainer into legacyPull request: Move RenderSVGResourceContainer into legacy WebKit/WebKit#17914
Ticket: https://bugs.webkit.org/show_bug.cgi?id=261739
Status: Committed https://commits.webkit.org/268196@main (reviewed by Nikolas Zimmermann)
2023-09-24 - [LBSE] Errorous/unncessary repainting when viewBox is used on elementsPull request: [LBSE] Errorous/unnecessary repainting when viewBox is used on <svg> elements WebKit/WebKit#18136
Ticket: https://bugs.webkit.org/show_bug.cgi?id=258351
Status: Committed https://commits.webkit.org/269034@main (reviewed by Rob Buis)
2023-10-05 - [LBSE] Fix visual overflow computationPull request: [LBSE] Fix visual overflow computation WebKit/WebKit#18692
Ticket: https://bugs.webkit.org/show_bug.cgi?id=262694
Status: Committed https://commits.webkit.org/268981@main (reviewed by Rob Buis)
2023-10-07 - [LBSE] Incorrect clipping for non-opaque, outermost elementsPull request: [LBSE] Incorrect clipping for non-opaque, outermost <svg> elements WebKit/WebKit#18812
Ticket: https://bugs.webkit.org/show_bug.cgi?id=262843
Status: Committed https://commits.webkit.org/269360@main (reviewed by Rob Buis)
2023-10-07 - [LBSE] Garden mac-ventura-wk2-pixel / mac-ventura-wk2-lbse-text pixel test baselinesPull request: [LBSE] Garden mac-ventura-wk2-pixel / mac-ventura-wk2-lbse-text pixel test baselines WebKit/WebKit#18814
Ticket: https://bugs.webkit.org/show_bug.cgi?id=262851
Status: Committed https://commits.webkit.org/269050@main (unreviewed)
2023-09-21 - [LBSE] Add RenderSVGResourceContainerPull request: [LBSE] Add RenderSVGResourceContainer WebKit/WebKit#18017
Ticket: https://bugs.webkit.org/show_bug.cgi?id=261880
Status: Committed https://commits.webkit.org/269522@main (reviewed by Nikolas Zimmermann)
2023-09-21 - [LBSE] Add RenderSVGResourceClipperPull request: [LBSE] Add RenderSVGResourceClipper WebKit/WebKit#18286
Ticket: https://bugs.webkit.org/show_bug.cgi?id=261880
Status: Committed https://commits.webkit.org/269635@main (reviewed by Nikolas Zimmermann)
2023-10-24 - [LBSE] Rename RenderSVGResource -> LegacyRenderSVGResourcePull request: [LBSE] Rename RenderSVGResource -> LegacyRenderSVGResource WebKit/WebKit#19494
Ticket: https://bugs.webkit.org/show_bug.cgi?id=263595
Status: Committed https://commits.webkit.org/269784@main (reviewed by Rob Buis)
2023-10-24 - [LBSE] Switch baselines/expectations to macOS SonomaPull request: [LBSE] Switch baselines/expectations to macOS Sonoma WebKit/WebKit#19947
Ticket: https://bugs.webkit.org/show_bug.cgi?id=263612
Status: Committed https://commits.webkit.org/270175@main (unreviewed)
2023-10-25 - [LBSE] Fix RenderSVGResourceClipper introduction regressionsPull request: [LBSE] Fix RenderSVGResourceClipper introduction regressions WebKit/WebKit#19532
Ticket: https://bugs.webkit.org/show_bug.cgi?id=263650
Status: Committed https://commits.webkit.org/269774@main (reviewed by Nikolas Zimmermann)
2023-10-29 - [LBSE] Reduce SVG state in RenderLayerPull request: [LBSE] Reduce SVG state in RenderLayer WebKit/WebKit#19826
Ticket: https://bugs.webkit.org/show_bug.cgi?id=263847
Status: Committed https://commits.webkit.org/270088@main (reviewed by Nikolas Zimmermann)
2023-11-02 - [LBSE] Add RenderSVGResourceMasker
Pull request: [LBSE] Add RenderSVGResourceMasker WebKit/WebKit#19848
Ticket: https://bugs.webkit.org/show_bug.cgi?id=264049
Status: Committed https://commits.webkit.org/271153@main (reviewed by Nikolas Zimmermann)
2023-11-05 - SVG test gardeningPull request: SVG test gardening WebKit/WebKit#20008
Ticket: https://bugs.webkit.org/show_bug.cgi?id=264162
Status: Committed https://commits.webkit.org/270249@main (reviewed by Rob Buis)
2023-11-05 - [LBSE] Unbreak clipping (last minute regression)Pull request: [LBSE] Unbreak clipping (regression from 270088@main) WebKit/WebKit#20010
Ticket: https://bugs.webkit.org/show_bug.cgi?id=264224
Status: Committed https://commits.webkit.org/270248@main (reviewed by Rob Buis)
2023-11-05 - [LBSE] Rework SVG resource invalidationPull request: [LBSE] Rework SVG resource invalidation WebKit/WebKit#20016
Ticket: https://bugs.webkit.org/show_bug.cgi?id=264230
Status: Committed https://commits.webkit.org/270992@main (reviewed by Rob Buis)
2023-11-06 - [LBSE] Fix WPT test import/masking-path-06-b-manual.svg crashPull request: Fix WPT test import/masking-path-06-b-manual.svg crash WebKit/WebKit#20046
Ticket: https://bugs.webkit.org/show_bug.cgi?id=264269
Status: Committed https://commits.webkit.org/270321@main
2023-11-05 - [LBSE] Implement clip paths referencing other clip pathsPull request: [LBSE] Implement clip paths referencing other clip paths WebKit/WebKit#20034
Ticket: https://bugs.webkit.org/show_bug.cgi?id=264253
Status: Committed https://commits.webkit.org/270284@main
2023-11-07 - [LBSE] Update some test results after 270302@mainPull request: [LBSE] Update some test results after 270302@main WebKit/WebKit#20097
Ticket: https://bugs.webkit.org/show_bug.cgi?id=264332
Status: Committed https://commits.webkit.org/270389@main
2023-11-16 - [LBSE] Fix RenderSVGResourceClipper::resourceBoundingBox objectBoundingBox logicPull request: [LBSE] Fix RenderSVGResourceClipper (re)painting problems WebKit/WebKit#20605
Ticket: https://bugs.webkit.org/show_bug.cgi?id=264946
Status: Committed https://commits.webkit.org/270913@main
2023-11-20 - [LBSE] Move remaining resources to legacyPull request: [LBSE] Move remaining resources to legacy WebKit/WebKit#20739
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265125
Status: Committed https://commits.webkit.org/271008@main
2023-11-21 - [LBSE] Fix clip-rule in masksPull request: [LBSE] Fix clip-rule in masks WebKit/WebKit#20777
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265183
Status: Commited https://commits.webkit.org/271053 (reviewed by Nikolas Zimmermann)
2023-11-21 - [LBSE] Support clip-path shapesPull request: [LBSE] Support clip-path shapes WebKit/WebKit#20795
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265207
Status: Committed https://commits.webkit.org/271026@main
2023-11-22 - [LBSE] Fix clipping + SVGUseElement supportPull request: [LBSE] Fix clipping + SVGUseElement support WebKit/WebKit#20817
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265244
Status: Committed https://commits.webkit.org/271101@main (reviewed by Rob Buis)
2023-11-30 - [LBSE] Allow transforms on clip-path elementPull request: [LBSE] Allow transforms on clip-path element WebKit/WebKit#21100
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265573
Status: Committed https://commits.webkit.org/271630@main (reviewed by Nikolas Zimmermann)
2023-12-03 - [LBSE] Fix some masker issuesPull request: [LBSE] Fix some masker issues WebKit/WebKit#21238
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265755
Status: Committed https://commits.webkit.org/271631@main (reviewed by Nikolas Zimmermann)
2023-12-10 - [LBSE] Gardening - correct TestExpectationsPull request: [LBSE] Gardening - correct TestExpectations WebKit/WebKit#21607
Ticket: https://bugs.webkit.org/show_bug.cgi?id=266193
Status: Committed https://commits.webkit.org/271852@main (unreviewed)
2023-12-24 - [LBSE] Treat root svg with clip path as not obscuring backgroundPull request: [LBSE] Treat root svg with clip path as not obscuring background WebKit/WebKit#21114
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265589
Status: Committed https://commits.webkit.org/272486@main (reviewed by Nikolas Zimmermann)
2024-01-01 - [LBSE] Implement support for gradientsPull request: [LBSE] Implement support for gradients WebKit/WebKit#22292
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265138
Status: Committed https://commits.webkit.org/272653@main (reviewed by Rob Buis)
2024-01-02 - [LBSE] Gardening - regenerate outdated baselines using macOS Sonoma 14.2.1Pull request: [LBSE] Gardening - regenerate outdated baselines using macOS Sonoma 14.2.1 WebKit/WebKit#22295
Ticket: https://bugs.webkit.org/show_bug.cgi?id=266977
Status: Committed https://commits.webkit.org/272563@main (unreviewed)
2024-01-02 - [LBSE] Implement support for patternsPull request: [LBSE] Implement support for patterns WebKit/WebKit#22427
Ticket: https://bugs.webkit.org/show_bug.cgi?id=267041
Status: Committed https://commits.webkit.org/273757@main (reviewed by Nikolas Zimmermann)
2024-01-02 - [LBSE] Take transforms into account on mask/clip contentPull request: [LBSE] Take transforms into account on mask/clip content WebKit/WebKit#22379
Ticket: https://bugs.webkit.org/show_bug.cgi?id=267075
Status: Committed https://commits.webkit.org/273046@main (reviewed by Nikolas Zimmermann)
2024-01-18 - [LBSE] Fix svg/clip-path/clip-path-css-transform-002.svgPull request: [LBSE] Fix svg/clip-path/clip-path-css-transform-002.svg WebKit/WebKit#22855
Ticket: https://bugs.webkit.org/show_bug.cgi?id=267624
Status: Committed https://commits.webkit.org/273173@main (reviewed by Nikolas Zimmermann)
2024-01-18 - [LBSE] 'mask' / 'clipPath' (SVG) DOM changes should never trigger relayoutsPull request: [LBSE] 'mask' / 'clipPath' (SVG) DOM changes should never trigger relayouts WebKit/WebKit#22938
Ticket: https://bugs.webkit.org/show_bug.cgi?id=267732
Status: Committed https://commits.webkit.org/273293@main (reviewed by Rob Buis and Simon Fraser)
2024-01-21 - [LBSE] Fix css3/masking failuresPull request: [LBSE] Fix css3/masking failures WebKit/WebKit#22986
Ticket: https://bugs.webkit.org/show_bug.cgi?id=267775
Status: Committed https://commits.webkit.org/273273@main (reviewed by Nikolas Zimmermann)
2024-01-21 - [LBSE] Fix svg/clip-path/clip-path-on-overflowing.htmlPull request: [LBSE] Fix svg/clip-path/clip-path-on-overflowing.html WebKit/WebKit#23027
Ticket: https://bugs.webkit.org/show_bug.cgi?id=267832
Status: Committed https://commits.webkit.org/273495@main (reviewed by Nikolas Zimmermann)
2024-01-29 - [LBSE] Fix use-on-clip-path-with-transformation.svgPull request: [LBSE] Fix use-on-clip-path-with-transformation.svg WebKit/WebKit#23408
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268283
Status: Committed https://commits.webkit.org/274074@main (reviewed by Nikolas Zimmermann)
2024-01-30 - [LBSE] Implement support for markersPull request: [LBSE] Implement support for markers WebKit/WebKit#23513
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265137
Status: Committed https://commits.webkit.org/273820@main (reviewed by Rob Buis)
2024-01-30 - [LBSE] Fix css3/masking crashesPull request: [LBSE] Fix css3/masking crashes WebKit/WebKit#23514
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268381
Status: Committed https://commits.webkit.org/273760@main (reviewed by Nikolas Zimmermann)
2024-01-31 - [LBSE] Gardening - regenerate outdated baselines using macOS Sonoma 14.3Pull request: [LBSE] Gardening - regenerate outdated baselines using macOS Sonoma 14.3 WebKit/WebKit#23575
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268452
Status: Committed https://commits.webkit.org/273827@main (unreviewed)
2024-01-31 - [LBSE] Fix clipping/masking related assertion failure in debug buildsPull request: [LBSE] Fix clipping/masking related assertion failure in debug builds WebKit/WebKit#23576
Ticket: https://bugs.webkit.org/show_bug.cgi?id=267764
Status: Committed https://commits.webkit.org/273893@main (reviewed by Rob Buis)
2024-01-31 - [LBSE] Fix pattern related assertion failure in debug buildsPull request: [LBSE] Fix pattern related assertion failure in debug builds WebKit/WebKit#23605
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268488
Status: Committed https://commits.webkit.org/273944@main (reviewed by Rob Buis)
2024-01-31 - [LBSE] Unskip svg/dynamic-updatesPull request: [LBSE] Unskip svg/dynamic-updates WebKit/WebKit#23606
Ticket: https://bugs.webkit.org/show_bug.cgi?id=265147
Status: Committed https://commits.webkit.org/273900@main (reviewed by Rob Buis)
2024-01-31 - [LBSE] Expand test coveragePull request: [LBSE] Expand test coverage WebKit/WebKit#23667
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268543
Status: Committed https://commits.webkit.org/273904@main (reviewed by Rob Buis)
2024-02-02 - [LBSE] Fix pattern related dynamic-updates testsPull request: [LBSE] Fix pattern related dynamic-updates tests WebKit/WebKit#23734
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268610
Status: Committed https://commits.webkit.org/273985@main (reviewed by Nikolas Zimmermann)
2024-02-02 - [LBSE] Gardening - regenerate a few outdated baselinesPull request: [LBSE] Gardening - regenerate a few outdated baselines WebKit/WebKit#23737
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268614
Status: Committed https://commits.webkit.org/273992@main (unreviewed)
2024-02-02 - [LBSE] Code cleanup after implementing all but one resourcePull request: [LBSE] Code cleanup after implementing all but one resource WebKit/WebKit#23740
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268615
Status: Committed https://commits.webkit.org/274053@main (reviewed by Rob Buis)
2024-02-06 - [LBSE] Fix svg/custom/use-nested-symbol-viewport.htmlPull request: [LBSE] Fix svg/custom/use-nested-symbol-viewport.html WebKit/WebKit#23908
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268810
Status: Committed https://commits.webkit.org/274138@main (reviewed by Nikolas Zimmermann)
2024-02-06 - [LBSE] Allow tests that pass with the default tolerancePull request: [LBSE] Allow tests that pass with the default tolerance WebKit/WebKit#23910
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268812
Status: Committed https://commits.webkit.org/274143@main (reviewed by Nikolas Zimmermann)
2024-02-07 - Unify cycle detection logic for legacy & LBSEPull request:Unify cycle detection logic for legacy & LBSE WebKit/WebKit#23995
Ticket: https://bugs.webkit.org/show_bug.cgi?id=268909
Status: Committed https://commits.webkit.org/274392@main (reviewed by Rob Buis)
2024-02-12 - Fix custom/pattern-userSpaceOnUse-userToBaseTransform.xhtmlPull request: Fix custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml WebKit/WebKit#24279
Ticket: https://bugs.webkit.org/show_bug.cgi?id=269234
Status: Committed https://commits.webkit.org/275117@main (reviewed by Nikolas Zimmermann)
2024-02-21 - Improve SVG MarkersPull request: Improve SVG Markers WebKit/WebKit#24814
Ticket: https://bugs.webkit.org/show_bug.cgi?id=269789
Status: Committed https://commits.webkit.org/275167@main (reviewed by Nikolas Zimmermann)
2024-02-21 - [LBSE] Support outlinesPull request: [LBSE] Support outlines WebKit/WebKit#24953
Ticket: https://bugs.webkit.org/show_bug.cgi?id=269917
Status: Committedhttps://commits.webkit.org/275682@main (reviewed by Nikolas Zimmermann)
2024-02-26 - [LBSE] Gardening, update mac-sonoma-wk2-lbse-text baselinePull request: [LBSE] Gardening, update mac-sonoma-wk2-lbse-text baseline WebKit/WebKit#25104
Ticket: https://bugs.webkit.org/show_bug.cgi?id=270086
Status: Committed https://commits.webkit.org/275321@main (unreviewed)
2024-02-26 - [LBSE] Fix MotionMark repaint issuesPull request: [LBSE] Fix MotionMark repaint issues WebKit/WebKit#25118
Ticket: https://bugs.webkit.org/show_bug.cgi?id=270103
Status: Committed https://commits.webkit.org/275702@main (reviewed by Rob Buis)
2024-03-01 - [LBSE] Fix svg/repaint/image-with-clip-path.svgPull request: [LBSE] Fix svg/repaint/image-with-clip-path.svg WebKit/WebKit#25191
Ticket: https://bugs.webkit.org/show_bug.cgi?id=270187
Status: Committed https://commits.webkit.org/275683@main (reviewed by Nikolas Zimmermann)
2024-03-21 - [LBSE] Only clipPath should be an opportunistic stacking contextPull request: [LBSE] Only clipPath should be an opportunistic stacking context WebKit/WebKit#25343
Ticket: https://bugs.webkit.org/show_bug.cgi?id=270338
Status: Committed https://commits.webkit.org/276449@main (reviewed by Nikolas Zimmermann)
2024-04-10 - [LBSE] Fix performance of nested masksPull request: [LBSE] Fix performance of nested masks WebKit/WebKit#26035
Ticket: https://bugs.webkit.org/show_bug.cgi?id=271146
Status: Committed https://commits.webkit.org/277292@main (reviewed by Nikolas Zimmermann)
2024-04-10 - [LBSE] Improve RenderSVGResourcePatternPull request: [LBSE] Improve RenderSVGResourcePattern WebKit/WebKit#24245
Ticket: https://bugs.webkit.org/show_bug.cgi?id=269184
Status: Committed https://commits.webkit.org/277306@main (reviewed by Nikolas Zimmermann)
The text was updated successfully, but these errors were encountered: