You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's not possible to configure the BASE_URL for a domain starting with board, becouse https://board.myproject.com contains /board and the function checkBaseUrl of file run.js do this:
functioncheckBaseUrl(){constbaseUrl=process.env.BASE_URL;if(baseUrl){if(baseUrl.includes('/board')){returnerror('env.BASE_URL must point to the root of the webapp');}
I think that you can change the code to first check if the baseUrl format is not valid, then check why, somethink like this:
functioncheckBaseUrl(){constbaseUrl=process.env.BASE_URL;if(baseUrl&&!baseUrl.match(/^https?:\/\/(\.?\w+)+$/)){if(baseUrl.includes('/board')){returnerror('env.BASE_URL must point to the root of the webapp');}
Steps to Reproduce
try to configure the BASE_URL for a domain starting with board
Environment
Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
OS: [e.g. Windows 7]
Board version: [e.g. 1.0.0]
The text was updated successfully, but these errors were encountered:
Good catch. I think the check can be further simplified. It should basically prevent users from setting {TASK_BOARD}/board as the BASE_URL over {TASK_BOARD}.
Describe the Bug
It's not possible to configure the BASE_URL for a domain starting with board, becouse
https://board.myproject.com
contains/board
and the functioncheckBaseUrl
of file run.js do this:I think that you can change the code to first check if the baseUrl format is not valid, then check why, somethink like this:
Steps to Reproduce
try to configure the BASE_URL for a domain starting with board
Environment
The text was updated successfully, but these errors were encountered: