-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Solved) No env.reset() at the end of each training epoch. #67
Comments
Hello! I think the training code is logically the same as OpenAI's. Maybe you are misled by these two similar loops: https://github.com/openai/spinningup/blob/038665d62d569055401d91856abb287263096178/spinup/algos/pytorch/ppo/ppo.py#L299 and Line 173 in 728cce8
Hope it makes scene to you! |
Dear Huang, |
slDeng1003
changed the title
No env.reset() at the end of each training epoch.
(Solved) No env.reset() at the end of each training epoch.
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
【Existing code:】
Only reset the environment at the beginning of training loop, that is, only call env.reset() at the first epoch.
【Right(might) training paradigm】
I checked OpenAI spinning-up's implement of PPO https://github.com/openai/spinningup/blob/master/spinup/algos/pytorch/ppo/ppo.py, they do reset the env at the end of each epoch (same as reset it at the beginning of each epoch).
Correct me if I were wrong:)
P.S.: It;s still nice code!
The text was updated successfully, but these errors were encountered: