Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why start_new_session=True ? (sorry not really an issue) #243

Open
Tobi-De opened this issue Dec 21, 2023 · 0 comments
Open

Why start_new_session=True ? (sorry not really an issue) #243

Tobi-De opened this issue Dec 21, 2023 · 0 comments

Comments

@Tobi-De
Copy link

Tobi-De commented Dec 21, 2023

Hello, I hope you are doing great. This is a question rather than an issue. I recently had to use Honcho in a way that required it to run in the current user session. The default setting for Python's subprocess.Popen is to have start_new_session as False, but in Honcho, it was overridden and changed to True.

class Popen(subprocess.Popen):

    def __init__(self, cmd, **kwargs):
        start_new_session = kwargs.pop('start_new_session', True)

I'm primarily asking this out of genuine curiosity. I've resolved my issue by overriding the class and setting start_new_session back to False, but I'm wondering why it was changed in the first place. What am I missing here?

@Tobi-De Tobi-De changed the title Why start_new_session ? (sorry not really an issue) Why start_new_session=True ? (sorry not really an issue) Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant