Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Template): allow rendering boolean values as leafs #61

Closed
wants to merge 1 commit into from

Conversation

Ryman
Copy link
Member

@Ryman Ryman commented Aug 12, 2018

Fixes #60.

@Ryman Ryman requested a review from ninjabear August 12, 2018 13:01
@nico-abram
Copy link

Is there any reason this hasn't been merged in the past year?

@rjloura
Copy link

rjloura commented Feb 28, 2020

Thanks for fixing. It would be very helpful to have this merged soon. Any idea on timeline?

@cburgdorf
Copy link
Member

@Ryman @erickt Is this still alive?

@ninjabear
Copy link
Collaborator

Hi all, I feel bad that I've not looked at this. @Ryman's fix looks fine to me but we will need to add it to a release. I think we're prevented doing that until we also solve #63. I will take a look since this is obviously a nuisance!

@ninjabear
Copy link
Collaborator

This looks fine to me, I've packaged it up in #71, but I think we'll have to find someone to actually publish the crate as this seems to be a manual process that requires creds.

Closing in favour of #71

@ninjabear ninjabear closed this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on rendering boolean
5 participants