add visual indication that chrome has muted

[ajoslin103]

add visual indication that chrome has muted

then you can mute&unmute the site to get the sound back.

(god I love this thing 🥇

[nickdotht]

Hey there, thanks for the feedback. And yeah, I'm loving it too :)

If I understand correctly, you want it to display some kind of badge that indicates whether the current tab is muted or not. Correct?

[ajoslin103]

This thing is great! It’s a good thing I work at home, or people will try to fill my speakers with glue !! Basically, I had the extensions page open and there were errors from chrome saying that it’d blocked the sound because the user hadn’t done the required interactions for sound — I don’t know how to deal with it except to do something that causes chrome to show the mute icon - then th euser would un-mute it for you If you go to the extension and click on the errors button it explains it Al;

…

On Feb 18, 2020, at 11:26 AM, Nick Rameau ***@***.***> wrote: Hey there, thanks for the feedback. And yeah, I'm loving it too :) If I understand correctly, you want it to display some kind of badge that indicates whether the current tab is muted or not. Correct? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADML5IF2HCKY7S3J5OTTLDRDQDZXANCNFSM4KXG2EQQ>.

[nickdotht]

Ah, yeah, I noticed this error. It's about the AudioContext API. Chrome pauses the sound by default until the user interacts with the page. I'll find a turnaround for this. Meanwhile, I added this to the TODO list on the README.

[ajoslin103]

It would be perfect if there was some way to get chrome google would to show the mute icon I wonder if you can ask for a page to be muted?

…

On Feb 18, 2020, at 12:21 PM, Nick Rameau ***@***.***> wrote: Ah, yeah, I noticed this error. It's about the AudioContext API. Chrome pauses the sound by default until the user interacts with the page. I'll find a turnaround for this. Meanwhile, I added this to the TODO list on the README. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADML5JMBS2D4L7HY5ZLGCDRDQKJRANCNFSM4KXG2EQQ>.

[nickdotht]

Ah, this is possible, sort of. It only shows up if the page is muted AND is playing a sound tho.

You can mute a page/tab by right clicking on the tab and selecting "Mute Site", but it won't show up the muted speaker icon until the tab starts playing a sound.

[ajoslin103]

yeah, the way I re-enable your extension is to mute+unmute I guess you can’t request that google mute a site? (then do that when you catch the error)

…

On Feb 18, 2020, at 1:30 PM, Nick Rameau ***@***.***> wrote: Ah, this is possible, sort of. It only shows up if the page is muted AND is playing a sound tho. You can mute a page/tab by right clicking on the tab and selecting "Mute Site", but it won't show up the muted speaker icon until the tab starts playing a sound. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADML5N7C3RKXNC775URHM3RDQSMNANCNFSM4KXG2EQQ>.

[nickdotht]

I believe it's because I'm using the AudioContext API the wrong way for now. I'll try to fix this issue on my next iteration and hopefully you won't have to do this anymore.