-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Maintainer #77
Comments
Thanks a lot :) |
@MarkoMackic Congratunaltions! @niccokunzmann I'm not sure if it makes sense to merge any PR asap. If a PR contains some bug fix then it makes sense. Otherwise it probably should be strongly reviewed by all contributors :) |
I found this and this and saw it works, too if we welcome the person and the code. They are more willing to fix their issue and those of other people when they do not get a guilty by default review. Also: if we have one version on pypi with the feature the person needs and it is taken out in the future, it is of help to one person already. I like the innocent until proven otherwise approach. Here is another video about merging pull-request: https://youtu.be/fh89cdAIiNg?t=31m15s |
@niccokunzmann Ok, this is your repo, and this is your choice. |
@MarkoMackic You contributed to the repository and so, I give you permission to maintain it.
The idea: When people would like to contribute, we want to be responsive and merge their pull-requests fast, so that they continue to improve the repository.
What you can do additionally from now on:
What you can do but should not:
master
/deploy branches likev2.0
What stays the same:
You can try it out or just ignore it. Here is the invitation.
What do you say?
The text was updated successfully, but these errors were encountered: