Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licence issue #28

Open
tasogare3710 opened this issue Jun 13, 2022 · 6 comments
Open

Licence issue #28

tasogare3710 opened this issue Jun 13, 2022 · 6 comments

Comments

@tasogare3710
Copy link

A copyright notice and the permission notice is required to comply with the MIT license.

So, the correct way to change the 1b8508d (this commit has lost the copyright notice) is not to delete the MIT license file but to add the ASL2 file.

@nical
Copy link
Owner

nical commented Jun 13, 2022

Oops! my intentent was to add LICENCE-APPACHE and a LICENSE-MIT files to replace the LICENSE file but I apparently forgot to git-add them.

@nical
Copy link
Owner

nical commented Jun 13, 2022

I just pushed the files. Does it make more sense now?

@tasogare3710
Copy link
Author

I'm not a legal expert, but i think it looks good.

@tasogare3710
Copy link
Author

oh, the year of copyright is different.

Copyright 2016 Nicolas Silva

Copyright (c) 2013 Nicolas Silva

@nical
Copy link
Owner

nical commented Jun 14, 2022

Good catch! I updated them to the year of the first commit.

@tasogare3710
Copy link
Author

I think it's step better, but after replying, I noticed the following the how to.

https://www.apache.org/licenses/LICENSE-2.0

Include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file that references the License.

I think it is best to duplicate the ASL contents into the LICENSE-APACHE file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants