Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiosocks.LoginAuthenticationFailed is not raised on auth error #44

Open
jruere opened this issue Jun 30, 2021 · 0 comments
Open

aiosocks.LoginAuthenticationFailed is not raised on auth error #44

jruere opened this issue Jun 30, 2021 · 0 comments

Comments

@jruere
Copy link

jruere commented Jun 30, 2021

Instead, aiosocks.SocksError is raised saying there was an auth error.

AFAICS, this happens because in aiosocks.protocols.BaseSocksProtocol.negotiate, on line 58, exception aiosocks.SocksError is caught, which is a parent of aiosocks.LoginAuthenticationFailed and a brand new aiosocks.SocksError is created and raised.

No idea why that is done but the result is that aiosocks.LoginAuthenticationFailed never actually reaches the code using aiosocks.

Is this intentional?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jruere