diff --git a/change/@ni-nimble-angular-a3a80e57-4706-4f26-a972-f75bb74839b0.json b/change/@ni-nimble-angular-a3a80e57-4706-4f26-a972-f75bb74839b0.json new file mode 100644 index 0000000000..11d380d41b --- /dev/null +++ b/change/@ni-nimble-angular-a3a80e57-4706-4f26-a972-f75bb74839b0.json @@ -0,0 +1,7 @@ +{ + "type": "minor", + "comment": "Add missing string to core label provider", + "packageName": "@ni/nimble-angular", + "email": "jattasNI@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/change/@ni-nimble-blazor-77c0e32a-3428-4b68-b738-579b28432867.json b/change/@ni-nimble-blazor-77c0e32a-3428-4b68-b738-579b28432867.json new file mode 100644 index 0000000000..33a7336b7d --- /dev/null +++ b/change/@ni-nimble-blazor-77c0e32a-3428-4b68-b738-579b28432867.json @@ -0,0 +1,7 @@ +{ + "type": "minor", + "comment": "Add missing string to core label provider", + "packageName": "@ni/nimble-blazor", + "email": "jattasNI@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/packages/angular-workspace/nimble-angular/label-provider/core/nimble-label-provider-core-with-defaults.directive.ts b/packages/angular-workspace/nimble-angular/label-provider/core/nimble-label-provider-core-with-defaults.directive.ts index 63d82cdbfb..69607f2442 100644 --- a/packages/angular-workspace/nimble-angular/label-provider/core/nimble-label-provider-core-with-defaults.directive.ts +++ b/packages/angular-workspace/nimble-angular/label-provider/core/nimble-label-provider-core-with-defaults.directive.ts @@ -20,5 +20,6 @@ export class NimbleLabelProviderCoreWithDefaultsDirective { this.elementRef.nativeElement.popupIconInformation = $localize`:Nimble popup icon - information|:Information`; this.elementRef.nativeElement.filterSearch = $localize`:Nimble select - search items|:Search`; this.elementRef.nativeElement.filterNoResults = $localize`:Nimble select - no items|:No items found`; + this.elementRef.nativeElement.loading = $localize`:Nimble loading - loading|:Loading…`; } } \ No newline at end of file diff --git a/packages/angular-workspace/nimble-angular/label-provider/core/nimble-label-provider-core.directive.ts b/packages/angular-workspace/nimble-angular/label-provider/core/nimble-label-provider-core.directive.ts index 17fa20a4a7..eff2c01cd6 100644 --- a/packages/angular-workspace/nimble-angular/label-provider/core/nimble-label-provider-core.directive.ts +++ b/packages/angular-workspace/nimble-angular/label-provider/core/nimble-label-provider-core.directive.ts @@ -77,4 +77,12 @@ export class NimbleLabelProviderCoreDirective { @Input('filter-no-results') public set filterNoResults(value: string | undefined) { this.renderer.setProperty(this.elementRef.nativeElement, 'filterNoResults', value); } + + public get loading(): string | undefined { + return this.elementRef.nativeElement.loading; + } + + @Input('loading') public set loading(value: string | undefined) { + this.renderer.setProperty(this.elementRef.nativeElement, 'loading', value); + } } \ No newline at end of file diff --git a/packages/angular-workspace/nimble-angular/label-provider/core/tests/nimble-label-provider-core-with-defaults.directive.spec.ts b/packages/angular-workspace/nimble-angular/label-provider/core/tests/nimble-label-provider-core-with-defaults.directive.spec.ts index 50a4b6bade..759303c736 100644 --- a/packages/angular-workspace/nimble-angular/label-provider/core/tests/nimble-label-provider-core-with-defaults.directive.spec.ts +++ b/packages/angular-workspace/nimble-angular/label-provider/core/tests/nimble-label-provider-core-with-defaults.directive.spec.ts @@ -35,7 +35,8 @@ describe('Nimble LabelProviderCore withDefaults directive', () => { [computeMsgId('Warning', 'Nimble popup icon - warning')]: 'Translated warning', [computeMsgId('Information', 'Nimble popup icon - information')]: 'Translated information', [computeMsgId('Search', 'Nimble select - search items')]: 'Translated search', - [computeMsgId('No items found', 'Nimble select - no items')]: 'Translated no items found' + [computeMsgId('No items found', 'Nimble select - no items')]: 'Translated no items found', + [computeMsgId('Loading…', 'Nimble loading - loading')]: 'Translated loading' }); const fixture = TestBed.createComponent(TestHostComponent); const testHostComponent = fixture.componentInstance; @@ -52,5 +53,6 @@ describe('Nimble LabelProviderCore withDefaults directive', () => { expect(labelProvider.popupIconInformation).toBe('Translated information'); expect(labelProvider.filterSearch).toBe('Translated search'); expect(labelProvider.filterNoResults).toBe('Translated no items found'); + expect(labelProvider.loading).toBe('Translated loading'); }); }); diff --git a/packages/blazor-workspace/NimbleBlazor/Components/NimbleLabelProviderCore.razor b/packages/blazor-workspace/NimbleBlazor/Components/NimbleLabelProviderCore.razor index f5a2274346..04e4a5e134 100644 --- a/packages/blazor-workspace/NimbleBlazor/Components/NimbleLabelProviderCore.razor +++ b/packages/blazor-workspace/NimbleBlazor/Components/NimbleLabelProviderCore.razor @@ -8,5 +8,6 @@ popup-icon-information="@PopupIconInformation" filter-search="@FilterSearch" filter-no-results="@FilterNoResults" + loading="@Loading" @attributes="AdditionalAttributes"> diff --git a/packages/blazor-workspace/NimbleBlazor/Components/NimbleLabelProviderCore.razor.cs b/packages/blazor-workspace/NimbleBlazor/Components/NimbleLabelProviderCore.razor.cs index eeb080d23a..743aa336cd 100644 --- a/packages/blazor-workspace/NimbleBlazor/Components/NimbleLabelProviderCore.razor.cs +++ b/packages/blazor-workspace/NimbleBlazor/Components/NimbleLabelProviderCore.razor.cs @@ -31,6 +31,9 @@ public partial class NimbleLabelProviderCore : ComponentBase [Parameter] public string? FilterNoResults { get; set; } + [Parameter] + public string? Loading { get; set; } + /// /// Gets or sets a collection of additional attributes that will be applied to the created element. /// diff --git a/packages/blazor-workspace/Tests/NimbleBlazor.Tests/Unit/Components/NimbleLabelProviderCoreTests.cs b/packages/blazor-workspace/Tests/NimbleBlazor.Tests/Unit/Components/NimbleLabelProviderCoreTests.cs index 1794135ea6..d82acf3377 100644 --- a/packages/blazor-workspace/Tests/NimbleBlazor.Tests/Unit/Components/NimbleLabelProviderCoreTests.cs +++ b/packages/blazor-workspace/Tests/NimbleBlazor.Tests/Unit/Components/NimbleLabelProviderCoreTests.cs @@ -38,6 +38,7 @@ public void NimbleLabelProviderCore_SupportsAdditionalAttributes() [InlineData(nameof(NimbleLabelProviderCore.PopupIconInformation))] [InlineData(nameof(NimbleLabelProviderCore.FilterSearch))] [InlineData(nameof(NimbleLabelProviderCore.FilterNoResults))] + [InlineData(nameof(NimbleLabelProviderCore.Loading))] public void NimbleLabelProviderCore_LabelIsSet(string propertyName) { var labelValue = propertyName + "UpdatedValue";