WaferMap test expectations are not executing

[rajsite]

🧹 Tech Debt

Several wafer map tests are resulting in warns on nimble builds such as the following: https://github.com/ni/nimble/actions/runs/7475603903/job/20344086522#step:17:262

'Spec 'Wafermap Prerendering module with undefined values should have empty color fill style' has no expectations.'

The warning states that no expect statements are running for the test. However the source of the test shows expect statements:

nimble/packages/nimble-components/src/wafer-map/tests/prerendering.coloring.spec.ts

Lines 327 to 331 in e78cd37

	it('should have empty color fill style', () => {
	for (const dieRenderInfo of prerenderingModule.diesRenderInfo) {
	expect(dieRenderInfo.fillStyle).toEqual(emptyDieColor);
	}
	});

Seems like the tests are incorrectly written / not validating behaviors as expected.

The pattern that likely let this issue through is that the tests have conditionally executing expect statements which is an issue discussed here: ni/javascript-styleguide#125 (comment)

To address this tech debt the wafer map tests should be hardened to avoid conditionally executing expect statements as discussed in the above style guide issue.

[m-akinc]

@munteannatan Just a heads up.