Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual design for @mention support in rich text components #1595

Closed
1 of 3 tasks
vivinkrishna-ni opened this issue Oct 12, 2023 · 2 comments
Closed
1 of 3 tasks

Visual design for @mention support in rich text components #1595

vivinkrishna-ni opened this issue Oct 12, 2023 · 2 comments
Assignees
Labels
client request Client team would immediately benefit from this change visual design Visual design work item

Comments

@vivinkrishna-ni
Copy link
Contributor

vivinkrishna-ni commented Oct 12, 2023

📌 Request Background

Both the nimble-rich-text-editor and nimble-rich-text-viewer are used in the SLE application for the comments feature and here is the link to the issue: #1288

As part of the comments in SLE, @mention is a key feature to tag or mention other users in the organization and notify them if mentioned in a comment.

Interaction design: https://www.figma.com/file/Q5SU1OwrnD08keon3zObRX/SystemLink-orig?type=design&node-id=7248-114254&mode=design&t=2HcoatDFr9QHDRJd-0

Existing visual design for nimble-rich-text-editor: https://www.figma.com/file/PO9mFOu5BCl8aJvFchEeuN/Nimble_Components?type=design&node-id=2482%3A82389&mode=dev

🎯 Core Requirements

  • The @mention text in the editor and viewer should be a different color like in the interaction design
  • Visual design for dropdown when @ is added in the editor for all supported themes
  • @mention text in different states like disabled, error state, and in different themes

🍆 Non-requirements

🥅 Acceptance Criteria

  • Visual Design Spec submitted (link)
  • Visual Design Spec reviewed by design team
  • Visual Design Spec reviewed by dev team
@vivinkrishna-ni vivinkrishna-ni added triage New issue that needs to be reviewed client request Client team would immediately benefit from this change visual design Visual design work item labels Oct 12, 2023
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Oct 17, 2023
@RickA-NI
Copy link

Brandon said he took care of this already. Did the team get what they needed?

@jattasNI
Copy link
Contributor

@RickA-NI @NIbokeefe When I look at the Text Area page of the Nimble_Components Figma, I don't see designs for the questions under the "Core requirements" section above. I may be missing something or there may be a miscommunication about what's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client request Client team would immediately benefit from this change visual design Visual design work item
Projects
Development

No branches or pull requests

5 participants