From bd0d2742055c429d7c09fb3113fff651ccb0aa30 Mon Sep 17 00:00:00 2001 From: Jesse Attas Date: Thu, 14 Nov 2024 08:22:59 -0600 Subject: [PATCH] Add and update latest icons (#2468) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request ## ๐Ÿคจ Rationale Fixes #2466 ## ๐Ÿ‘ฉโ€๐Ÿ’ป Implementation Followed CONTRIBUTING. Brandon's proposed names matched FontAwesome with the following exceptions: 1. paper-airplane -> paper-plane 2. star-8-point -> no font awesome equivalent, went with Brandon's suggestion 3. rectangle-lines -> no font awesome equivalent, went with Brandon's suggestion (name aligns with existing rectangle-check-lines) ## ๐Ÿงช Testing Verified changing severity affects color of new icons Accepted Chromatic diffs. There are a lot because the pencil icon is used in many matrix tests ## โœ… Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com> --- ...-c49db1dd-d1ad-4ad5-bc0a-251b5c0883df.json | 7 +++++++ ...-151fa8d5-866f-4712-91bb-c1a16ef76d71.json | 7 +++++++ .../src/icon-base/tests/icon-metadata.ts | 21 +++++++++++++++++++ .../dist/icons/svg/floppy-disk-pen_16x16.svg | 4 +--- .../dist/icons/svg/lightbulb_16x16.svg | 5 +++++ .../dist/icons/svg/microphone_16x16.svg | 7 +++++++ .../dist/icons/svg/mountain-sun_16x16.svg | 5 +++++ .../dist/icons/svg/paper-plane_16x16.svg | 4 ++++ .../dist/icons/svg/paperclip_16x16.svg | 5 +++++ .../dist/icons/svg/pencil_16x16.svg | 7 ++++--- .../dist/icons/svg/rectangle-lines_16x16.svg | 4 ++++ .../dist/icons/svg/star-8-point_16x16.svg | 5 +++++ packages/storybook/.storybook/preview.js | 2 +- 13 files changed, 76 insertions(+), 7 deletions(-) create mode 100644 change/@ni-nimble-components-c49db1dd-d1ad-4ad5-bc0a-251b5c0883df.json create mode 100644 change/@ni-nimble-tokens-151fa8d5-866f-4712-91bb-c1a16ef76d71.json create mode 100644 packages/nimble-tokens/dist/icons/svg/lightbulb_16x16.svg create mode 100644 packages/nimble-tokens/dist/icons/svg/microphone_16x16.svg create mode 100644 packages/nimble-tokens/dist/icons/svg/mountain-sun_16x16.svg create mode 100644 packages/nimble-tokens/dist/icons/svg/paper-plane_16x16.svg create mode 100644 packages/nimble-tokens/dist/icons/svg/paperclip_16x16.svg create mode 100644 packages/nimble-tokens/dist/icons/svg/rectangle-lines_16x16.svg create mode 100644 packages/nimble-tokens/dist/icons/svg/star-8-point_16x16.svg diff --git a/change/@ni-nimble-components-c49db1dd-d1ad-4ad5-bc0a-251b5c0883df.json b/change/@ni-nimble-components-c49db1dd-d1ad-4ad5-bc0a-251b5c0883df.json new file mode 100644 index 0000000000..0e3de0f794 --- /dev/null +++ b/change/@ni-nimble-components-c49db1dd-d1ad-4ad5-bc0a-251b5c0883df.json @@ -0,0 +1,7 @@ +{ + "type": "minor", + "comment": "Add / update several icons", + "packageName": "@ni/nimble-components", + "email": "jattasNI@users.noreply.github.com", + "dependentChangeType": "minor" +} diff --git a/change/@ni-nimble-tokens-151fa8d5-866f-4712-91bb-c1a16ef76d71.json b/change/@ni-nimble-tokens-151fa8d5-866f-4712-91bb-c1a16ef76d71.json new file mode 100644 index 0000000000..0526eb199a --- /dev/null +++ b/change/@ni-nimble-tokens-151fa8d5-866f-4712-91bb-c1a16ef76d71.json @@ -0,0 +1,7 @@ +{ + "type": "minor", + "comment": "Add / update several icons", + "packageName": "@ni/nimble-tokens", + "email": "jattasNI@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/packages/nimble-components/src/icon-base/tests/icon-metadata.ts b/packages/nimble-components/src/icon-base/tests/icon-metadata.ts index 147211d100..e19bf8c52e 100644 --- a/packages/nimble-components/src/icon-base/tests/icon-metadata.ts +++ b/packages/nimble-components/src/icon-base/tests/icon-metadata.ts @@ -382,6 +382,9 @@ export const iconMetadata: { IconLayerGroup: { tags: ['jobs'] }, + IconLightbulb: { + tags: ['suggested', 'prompt', 'idea', 'think'] + }, IconLightningBolt: { tags: ['active jobs'] }, @@ -409,6 +412,9 @@ export const iconMetadata: { IconMarkdown: { tags: [] }, + IconMicrophone: { + tags: ['talk to text', 'speech', 'speak', 'sound', 'audio'] + }, IconMinus: { tags: ['mixed checkbox'] }, @@ -418,6 +424,9 @@ export const iconMetadata: { IconMobile: { tags: ['phone'] }, + IconMountainSun: { + tags: ['image', 'browse'] + }, IconNi: { tags: ['National Instruments', 'logo', 'product'] }, @@ -433,6 +442,12 @@ export const iconMetadata: { IconOutwardSquaresThree: { tags: ['undeploy'] }, + IconPaperclip: { + tags: ['attachment', 'add document', 'browse'] + }, + IconPaperPlane: { + tags: ['send', 'relay', 'submit'] + }, IconPaste: { tags: ['clipboard'] }, @@ -454,6 +469,9 @@ export const iconMetadata: { IconRectangleCheckLines: { tags: ['test', 'plan'] }, + IconRectangleLines: { + tags: ['defined', 'paper', 'paragraph', 'sentence', 'words'] + }, IconRunningArrow: { tags: ['status', 'running'] }, @@ -502,6 +520,9 @@ export const iconMetadata: { IconSquareX: { tags: ['quit', 'end', 'abort', 'stop', 'terminate'] }, + IconStar8Point: { + tags: ['create new', 'burst'] + }, IconStopSquare: { tags: ['quit', 'end'] }, diff --git a/packages/nimble-tokens/dist/icons/svg/floppy-disk-pen_16x16.svg b/packages/nimble-tokens/dist/icons/svg/floppy-disk-pen_16x16.svg index d47d98dc8c..e060092ec1 100644 --- a/packages/nimble-tokens/dist/icons/svg/floppy-disk-pen_16x16.svg +++ b/packages/nimble-tokens/dist/icons/svg/floppy-disk-pen_16x16.svg @@ -1,7 +1,5 @@ - + d="M7.80316,11h-.80316v-2h-2v2h-1v-3h6v.61652l1.46893-1.47058c.14978-.14978.32452-.26526.51361-.34674l.01746-3.25299c0-.33044-.21545-.5462-.54547-.5462H2.58319c-.32996,0-.58319.26733-.58319.59778v6.90222l1.5,1.49713,3.87225.0014.43091-.99854ZM3,7v-3h8v3H3ZM14.16608,8.93463l-1.07562-1.07526c-.25085-.25079-.65753-.25061-.90826.00037l-3.38831,3.39227-1.50317,3.48285,3.48682-1.49927,3.38885-3.39307c.25055-.25085.25037-.65723-.00031-.9079ZM8.48346,13.73785l-.19812-.19855.91547-2.11676.34088,1.06079,1.05768.34906-2.11591.90546Z" /> \ No newline at end of file diff --git a/packages/nimble-tokens/dist/icons/svg/lightbulb_16x16.svg b/packages/nimble-tokens/dist/icons/svg/lightbulb_16x16.svg new file mode 100644 index 0000000000..ae6c08502e --- /dev/null +++ b/packages/nimble-tokens/dist/icons/svg/lightbulb_16x16.svg @@ -0,0 +1,5 @@ + + + + \ No newline at end of file diff --git a/packages/nimble-tokens/dist/icons/svg/microphone_16x16.svg b/packages/nimble-tokens/dist/icons/svg/microphone_16x16.svg new file mode 100644 index 0000000000..b6152593af --- /dev/null +++ b/packages/nimble-tokens/dist/icons/svg/microphone_16x16.svg @@ -0,0 +1,7 @@ + + + + + \ No newline at end of file diff --git a/packages/nimble-tokens/dist/icons/svg/mountain-sun_16x16.svg b/packages/nimble-tokens/dist/icons/svg/mountain-sun_16x16.svg new file mode 100644 index 0000000000..ef23bfd339 --- /dev/null +++ b/packages/nimble-tokens/dist/icons/svg/mountain-sun_16x16.svg @@ -0,0 +1,5 @@ + + + + \ No newline at end of file diff --git a/packages/nimble-tokens/dist/icons/svg/paper-plane_16x16.svg b/packages/nimble-tokens/dist/icons/svg/paper-plane_16x16.svg new file mode 100644 index 0000000000..3aeaca2fd8 --- /dev/null +++ b/packages/nimble-tokens/dist/icons/svg/paper-plane_16x16.svg @@ -0,0 +1,4 @@ + + + + \ No newline at end of file diff --git a/packages/nimble-tokens/dist/icons/svg/paperclip_16x16.svg b/packages/nimble-tokens/dist/icons/svg/paperclip_16x16.svg new file mode 100644 index 0000000000..06c797f3fe --- /dev/null +++ b/packages/nimble-tokens/dist/icons/svg/paperclip_16x16.svg @@ -0,0 +1,5 @@ + + + + \ No newline at end of file diff --git a/packages/nimble-tokens/dist/icons/svg/pencil_16x16.svg b/packages/nimble-tokens/dist/icons/svg/pencil_16x16.svg index 7d88e77d9c..d8c4c580d9 100644 --- a/packages/nimble-tokens/dist/icons/svg/pencil_16x16.svg +++ b/packages/nimble-tokens/dist/icons/svg/pencil_16x16.svg @@ -1,4 +1,5 @@ - - + + + \ No newline at end of file diff --git a/packages/nimble-tokens/dist/icons/svg/rectangle-lines_16x16.svg b/packages/nimble-tokens/dist/icons/svg/rectangle-lines_16x16.svg new file mode 100644 index 0000000000..6ca3589b03 --- /dev/null +++ b/packages/nimble-tokens/dist/icons/svg/rectangle-lines_16x16.svg @@ -0,0 +1,4 @@ + + + + \ No newline at end of file diff --git a/packages/nimble-tokens/dist/icons/svg/star-8-point_16x16.svg b/packages/nimble-tokens/dist/icons/svg/star-8-point_16x16.svg new file mode 100644 index 0000000000..cab6350110 --- /dev/null +++ b/packages/nimble-tokens/dist/icons/svg/star-8-point_16x16.svg @@ -0,0 +1,5 @@ + + + + \ No newline at end of file diff --git a/packages/storybook/.storybook/preview.js b/packages/storybook/.storybook/preview.js index c86f570624..d34312cb9b 100644 --- a/packages/storybook/.storybook/preview.js +++ b/packages/storybook/.storybook/preview.js @@ -105,5 +105,5 @@ configureActions({ depth: 1 }); -// Update the GUID on this line to trigger a turbosnap full rebuild: c9f91cc3-1168-433f-86e7-b93a9e395ba2 +// Update the GUID on this line to trigger a turbosnap full rebuild: d3f8a1b2-4c5d-4e7f-8a9e-1b2c3d4e5f6a // See https://www.chromatic.com/docs/turbosnap/#full-rebuilds