Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installdriver: prompt on fresh install #624

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

zhindes
Copy link
Collaborator

@zhindes zhindes commented Aug 7, 2024

What does this Pull Request accomplish?

This adds a prompt for confirmation before kicking off a fresh install. Previously, we only prompted on upgrade. This has two benefits:

  1. (Windows & Linux) Clarity on what is being installed
  2. (Linux) A chance to opt out before we march forward interacting with the package manager

I also made a few minor cleanups

  • removed unused variables
  • include the cycle-based version in the prompts

Why should this Pull Request be merged?

Closes #623

What testing has been done?

Validated on an upgrade scenario:

$ poetry run python -m nidaqmx installdriver
Installed NI-DAQmx version is 23.5.0. Latest version available is 24.3.0 (2024Q2). Do you want to upgrade? (yes/no):

Fresh install scenario:

$ poetry run python -m nidaqmx installdriver
Latest NI-DAQmx version available is 24.3.0 (2024Q2). Do you want to install? (yes/no):

mypy happy

$ poetry run mypy
Success: no issues found in 175 source files

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
@zhindes zhindes enabled auto-merge (squash) August 8, 2024 18:42
@zhindes zhindes merged commit e8e7e0a into master Aug 8, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installdriver CLI doesn't prompt or indicate what versions are being downloaded/installed on a clean system
2 participants