Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish_NIMS.yml failures sometimes leave the repo's branch protection rules in an incorrect state #940

Open
bkeryan opened this issue Sep 25, 2024 · 0 comments
Labels
tech debt Non-user-visible improvement to code or development process triage New issue that needs to be reviewed

Comments

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 25, 2024

Tech Debt

https://github.com/ni/measurement-plugin-python/blob/main/.github/workflows/Publish_NIMS.yml uses the https://github.com/CasperWA/push-protected action, which edits the repo's branch protection rules to temporarily unprotect reviews. Sometimes the Publish_NIMS.yml workflow fails and the original branch protection rules are not restored.

We should figure out whether this issue is caused by upstream or we're doing something wrong. If it's a problem with upstream, we should report it.

It could also make sense to stop using push-protected, or to split updating the package version in pyproject.toml into a separate workflow to decouple it from publishing.

AB#2867320

@bkeryan bkeryan added tech debt Non-user-visible improvement to code or development process triage New issue that needs to be reviewed labels Sep 25, 2024
@bkeryan bkeryan mentioned this issue Sep 25, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Non-user-visible improvement to code or development process triage New issue that needs to be reviewed
Projects
None yet
Development

No branches or pull requests

1 participant