NI1017 fails to report errors in certain expressions.

[gregr-ni]

The code below should report an NI1017 error but does not because it is in the last section of a ternary operator. Errors in the first value of ternarys are reported correctly.

private static IEnumerable Ternary(IEnumerable numbers)
{
return numbers is null
? Enumerable.Empty()
: numbers.Where(n => n < 10).Select(n => $"{n}");
}

Likewise violations in a return statement are not reported. If you assign to a local then return the local, the error is reported.

private static int Expression(IEnumerable numbers)
{
return numbers.Where(n => n < 10).Select(n => n * 2).Max();
}

[Everest2020]

The reason why it fails to report is because by registration

csharp-styleguide/src/NationalInstruments.Analyzers/Style/ChainOfMethodsWithLambdasAnalyzer.cs

Line 38 in 3827066

context.RegisterSyntaxNodeAction(

The syntax node in the second example is InvocationExpression

Have to check that node as the root node