Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement faceting by two variables #207

Open
ThomUK opened this issue Jun 27, 2024 · 1 comment
Open

Implement faceting by two variables #207

ThomUK opened this issue Jun 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ThomUK
Copy link
Collaborator

ThomUK commented Jun 27, 2024

The current implementation of faceting accepts only one column name, and faceting is implemented using facet_wrap.

It would be convenient to be able to facet by two columns, and to implement using facet_grid instead.

This could be via:

  1. Changes to the main ptd_spc function
  2. Addition of a convenience wrapper function which makes unfaceted calls to ptd_spc, and then arranges the resulting plots using eg. {cowplot} or {patchwork}.

This issue is low priority because it's possible to do this manually either with cowplot or patchwork with a little effort. Raising an issue mainly because I needed it today, and to log the possible addition of functionality.

@Lextuga007 Lextuga007 added the enhancement New feature or request label Oct 7, 2024
@Lextuga007
Copy link
Member

How did you resolve this? Perhaps it could be listed as a vignette as added functionality along with other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants