Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting for points that are both improvement and concern #200

Open
andrjohns opened this issue Dec 17, 2023 · 1 comment
Open

Highlighting for points that are both improvement and concern #200

andrjohns opened this issue Dec 17, 2023 · 1 comment

Comments

@andrjohns
Copy link

I had a query about the approach to highlighting in the SPC visual, and I want to make sure that the final implementation is consistent with the NHSRplotthedots approach.

In the case where a given observation is part of both a special cause improvement and special cause concern pattern, how should it be highlighted?

The following toy example has two special cause concern patterns which overlap with a special cause improvement pattern:

yvals <- c(0:7,6:1)

test_data <- data.frame(y = yvals, obs=as.Date(Sys.Date() + seq_len(length(yvals))))

NHSRplotthedots::ptd_spc(test_data, value_field = y, date_field = obs)

Created on 2023-12-17 with reprex v2.0.2

Based on this, it looks like the current logic is that:

  • Astronomical point takes preference in highlighting
  • Patterns are highlighted in full before starting the highlighting of the next pattern
  • No preference in how improvement vs deterioration is highlighted

Is this the preferred logic to implement, or is there a particular decision tree that I should be following in highlighting?

@andrjohns
Copy link
Author

Also for information, one suggestion for these cases (credit to @alexmcqueen) was to use different outline vs fill colours for the points in question:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant