-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding annotations #139
Comments
Do we want to annotate the data frame, or the plots? I think the latter. I would argue against adding additional arguments where possible as it starts to bloat the api and makes it harder for a new user to get orientated. That said, for Or, we could add an argument to the plot functions that takes a data frame containing the dates of interventions (+ facet columns?) and draws these for you. I would more be in favour of using a more manual approach for one key reason: how do you make the code generic enough to handle any type of annotation that the user might want to add in? (thinking what happens if they want to label a point, or label a line, or dodge multiple labels so text doesn't overlap). I feel like that is something that if you want to do it, manually use annotate or other ggplot constructs (e.g. geom_text_repel from {ggrepel}) |
Based on a question in slack:
How do you annotate 2 or more points in the charts (let's say 2 QI interventions)?
Potential for an "annotations" argument, which would be a list of dates and annotation comments.
The text was updated successfully, but these errors were encountered: