-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(store): run plugins in injection context #2256
Conversation
62947de
to
210032e
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4c36c5c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
commit: |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +126B +0.1% Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (2)
Unchanged files (1)
Total files change -17B -0.01% Final result: ✅ View report in BundleMon website ➡️ |
210032e
to
0d9d9d8
Compare
In this commit, we enable plugin functions to run within the injection context. This allows plugin functions (but not classes) to call `inject` and access dependencies. Additionally, we've moved `compose` to the `Dispatcher` class since it was only used once. Keeping it in the `Dispatcher` ensures it isn't used elsewhere and can be safely inlined if needed.
0d9d9d8
to
4c36c5c
Compare
Code Climate has analyzed commit 4c36c5c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
In this commit, we enable plugin functions to run within the injection context. This allows plugin functions (but not classes) to call
inject
and access dependencies.Additionally, we've moved
compose
to theDispatcher
class since it was only used once. Keeping it in theDispatcher
ensures it isn't used elsewhere and can be safely inlined if needed.