-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: introduce schematics #2057
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e681ad0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
e82f720
to
32fe9c4
Compare
BundleMon (Integration Projects)Files updated (1)
Total files change +621B +0.96% Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command to call the schematics should include the package. Eg:
ng generate @ngxs/store:actions ...
It's fixed. Can you please have a look at it? |
Code Climate has analyzed commit e681ad0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.4% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Approving and merging, but could you add a subsequent PR to clarify the output of the store schematic?
Currently the description in the schematics page doesn't give me a clear idea, and the description of the output on the store page is non-descript.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information