Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: introduce schematics #2057

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

profanis
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@nx-cloud
Copy link

nx-cloud bot commented Sep 18, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e681ad0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@bundlemon
Copy link

bundlemon bot commented Sep 18, 2023

BundleMon (Integration Projects)

Files updated (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng15/dist-integration/main.(hash)
.js
63.95KB (+621B +0.96%) +1%

Total files change +621B +0.96%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command to call the schematics should include the package. Eg:

ng generate @ngxs/store:actions ...

@profanis
Copy link
Contributor Author

The command to call the schematics should include the package. Eg:

ng generate @ngxs/store:actions ...

It's fixed. Can you please have a look at it?

@codeclimate
Copy link

codeclimate bot commented Sep 26, 2023

Code Climate has analyzed commit e681ad0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.4% change).

View more on Code Climate.

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Approving and merging, but could you add a subsequent PR to clarify the output of the store schematic?
Currently the description in the schematics page doesn't give me a clear idea, and the description of the output on the store page is non-descript.

@markwhitfeld markwhitfeld merged commit 5942e46 into ngxs:master Sep 26, 2023
8 checks passed
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants