-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: introduce schematics #2049
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7d8d217. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
0f13bd2
to
b8b23fd
Compare
BundleMon (Integration Projects)Unchanged files (1)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
b8b23fd
to
a219c04
Compare
a219c04
to
e899de5
Compare
Code Climate has analyzed commit 7d8d217 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about having a schematics page that has all of this info, and then the necessary sections link to that page?
Or we add a schematics page that could list the different schematics and link to these sections on these different pages.
I'm neither way on this. What do you think?
That was my first approach. I then put myself in the shoes of a newcomer and decided to change that. A newcomer will visit the documentation and will try to have NGXS in his/her application by following more or less a step-by-step flow. |
Then I am happy to keep it as is, but can we just add a Schematics page that just lists out the different schematics, and links out to the sections of the pages that you have listed. |
I have integrated gitbook on my fork to have a visual representation of what I am doing. I assume it auto changed the Summary page. I am reverting it back |
I am closing this PR since GITBOOK integration messed up my commits |
This PR has a dependency on #2032