Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

Is this repo being maintaned? If so, are there any plans to update/sync it with the syntax used in ngrx/example-app? #47

Closed
kemalcany opened this issue Mar 16, 2017 · 1 comment

Comments

@kemalcany
Copy link

Hi guys,

@brandonroberts @MikeRyan52 and others, this is a great library and thank you very much for providing it!

However, there hasn't been much activity here lately and it would be good to know if there are any plans to synchronise it with the rest of ngrx suite?

I have a feeling that the ngrx/example-app repo demonstrates the latest syntax and best practices to use the ngrx components (such as store, effects etc.). This might not be the case, but i think a lot of people (including me) are taking it as a reference. It would be nice to have some symmetry across the different libraries imo..

This repo is out of sync with the syntax there. For example, the actions doesn't export an Actions type (such as below, taken from the example-app

export type Actions
  = SearchAction
  | SearchCompleteAction
  | LoadAction
  | SelectAction;

Will there be any effort to implement a version like that? If not from you, would you welcome any help with that?

Cheers

@llwt
Copy link

llwt commented Mar 23, 2017

Looks like there is a new version of the project coming soon: See vsavkin/router-store.

Ref #35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants