Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating webhook admission #185

Open
alex-bezek opened this issue Mar 14, 2023 · 0 comments
Open

Validating webhook admission #185

alex-bezek opened this issue Mar 14, 2023 · 0 comments
Labels
enhancement New feature or request priority/low

Comments

@alex-bezek
Copy link
Collaborator

alex-bezek commented Mar 14, 2023

Description

The controller should install a Validating Admission Webhook that can do complex validations of created k8s resources have configurations that we can't support.

Kubebuilder Implementing Webhooks Guide - https://book.kubebuilder.io/cronjob-tutorial/webhook-implementation.html

Use Case

The store can't process some fields like default backends, rules without hosts, etc. Right now these are ignored and logged in the controller. It would be a much better user experience though if these validations were done by the k8s server when first applying and could then block bad config.

Related issues

https://github.com/ngrok/kubernetes-ingress-controller/issues/176

@alex-bezek alex-bezek added enhancement New feature or request needs-triage Issues that need triage labels Mar 14, 2023
@alex-bezek alex-bezek added priority/low and removed needs-triage Issues that need triage labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/low
Projects
None yet
Development

No branches or pull requests

1 participant