Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the nginx client creation into the TcpBorderClient and HttpBorderClient #36

Open
ciroque opened this issue Apr 7, 2023 · 1 comment

Comments

@ciroque
Copy link
Collaborator

ciroque commented Apr 7, 2023

Is your feature request related to a problem? Please describe

No problem.

Synchronizer should not know about the NGINX Plus client. It should simply provide an HttpClient to the NewBorderClient factory method.

Describe the solution you'd like

In order to facilitate extensibility for various Border Server types, no assumptions should be made about which underlying client is used. The BorderClient implementation should contain that knowledge (e.g.: The HttpBorderClient and TcpBorderClient each know they need the NGINX Plus client, they can create those using the given HttpClient).

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@ciroque
Copy link
Collaborator Author

ciroque commented Apr 7, 2023

BorderClient::NewBorderClient should take an HttpClient instead of interface {} for the borderClient parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant