Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGCP TRD 4.5.1 - NAM, NFI, and NFN dropped from GrassA (EB010) #5286

Open
tdvorakcaci opened this issue Mar 10, 2022 · 2 comments
Open

MGCP TRD 4.5.1 - NAM, NFI, and NFN dropped from GrassA (EB010) #5286

tdvorakcaci opened this issue Mar 10, 2022 · 2 comments

Comments

@tdvorakcaci
Copy link

Describe the bug
GrassA (EB010) NAM, NFI, and NFN values are not preserved. Values lost with Hootenanny import.

To Reproduce
MGCP TRD 4.5.1 data imported using Hootenanny and MGCP translation option. Values should be preserved for named features when they exist.

Expected behavior
Preserve NAM, NFI, and NFN attribution.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

@mattjdnv
Copy link
Contributor

Like #5285 the translation server is fine with the values.

EB010 Area with names and unknown grass type
---------------
MGCP  EB010  Area
Raw: {"F_CODE":"EB010","NAM":"Feature Name","NFI":"NFI String","NFN":"NFN String","VEG":"0"}
LayerName:   Geometry: Area  Element Type:
In Attrs: F_CODE: :EB010:
In Attrs: NAM: :Feature Name:
In Attrs: NFI: :NFI String:
In Attrs: NFN: :NFN String:
In Attrs: VEG: :0:
LayerName:   Geometry: Area  Element Type:
Out tags: gndb_id: :NFN String:
Out tags: gndb_id:2: :NFI String:
Out tags: name: :Feature Name:
Out tags: natural: :grassland:
Out tags: vegetation:characteristic: :unknown:

OSM: {"gndb_id":"NFN String","gndb_id:2":"NFI String","name":"Feature Name","natural":"grassland","vegetation:characteristic":"unknown"}
LayerName:   Geometry: Area  Element Type: Way
In tags: gndb_id: :NFN String:
In tags: gndb_id:2: :NFI String:
In tags: name: :Feature Name:
In tags: natural: :grassland:
In tags: vegetation:characteristic: :unknown:
TableName 0: AEB010  FCode: undefined  Geom: Area
LayerName:   Geometry: Area  Element Type: Way
Out attrs: FCODE: :EB010:
Out attrs: NAM: :Feature Name:
Out attrs: NFI: :NFI String:
Out attrs: NFN: :NFN String:
Out attrs: VEG: :0:

Ogr: {"F_CODE":"EB010","NAM":"Feature Name","NFI":"NFI String","NFN":"NFN String","VEG":"0"}
LayerName:   Geometry: Area  Element Type:
In Attrs: FCODE: :EB010:
In Attrs: NAM: :Feature Name:
In Attrs: NFI: :NFI String:
In Attrs: NFN: :NFN String:
In Attrs: VEG: :0:
LayerName:   Geometry: Area  Element Type:
Out tags: gndb_id: :NFN String:
Out tags: gndb_id:2: :NFI String:
Out tags: name: :Feature Name:
Out tags: natural: :grassland:
Out tags: vegetation:characteristic: :unknown:

OSM: {"gndb_id":"NFN String","gndb_id:2":"NFI String","name":"Feature Name","natural":"grassland","vegetation:characteristic":"unknown"}

@mattjdnv
Copy link
Contributor

mattjdnv commented Mar 15, 2022

EB010 Area with names and grass
---------------
MGCP  EB010  Area
Raw: {"F_CODE":"EB010","NAM":"Feature Name","NFI":"NFI String","NFN":"NFN String","VEG":"8"}
LayerName:   Geometry: Area  Element Type:
In Attrs: F_CODE: :EB010:
In Attrs: NAM: :Feature Name:
In Attrs: NFI: :NFI String:
In Attrs: NFN: :NFN String:
In Attrs: VEG: :8:
LayerName:   Geometry: Area  Element Type:
Out tags: gndb_id: :NFN String:
Out tags: gndb_id:2: :NFI String:
Out tags: grassland:type: :grassland:
Out tags: name: :Feature Name:
Out tags: natural: :grassland:

OSM: {"gndb_id":"NFN String","gndb_id:2":"NFI String","grassland:type":"grassland","name":"Feature Name","natural":"grassland"}
LayerName:   Geometry: Area  Element Type: Way
In tags: gndb_id: :NFN String:
In tags: gndb_id:2: :NFI String:
In tags: grassland:type: :grassland:
In tags: name: :Feature Name:
In tags: natural: :grassland:
TableName 0: AEB010  FCode: undefined  Geom: Area
LayerName:   Geometry: Area  Element Type: Way
Out attrs: FCODE: :EB010:
Out attrs: NAM: :Feature Name:
Out attrs: NFI: :NFI String:
Out attrs: NFN: :NFN String:
Out attrs: VEG: :8:

Ogr: {"F_CODE":"EB010","NAM":"Feature Name","NFI":"NFI String","NFN":"NFN String","VEG":"8"}
LayerName:   Geometry: Area  Element Type:
In Attrs: FCODE: :EB010:
In Attrs: NAM: :Feature Name:
In Attrs: NFI: :NFI String:
In Attrs: NFN: :NFN String:
In Attrs: VEG: :8:
LayerName:   Geometry: Area  Element Type:
Out tags: gndb_id: :NFN String:
Out tags: gndb_id:2: :NFI String:
Out tags: grassland:type: :grassland:
Out tags: name: :Feature Name:
Out tags: natural: :grassland:

OSM: {"gndb_id":"NFN String","gndb_id:2":"NFI String","grassland:type":"grassland","name":"Feature Name","natural":"grassland"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants