Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] PFR_IDs for OL / defensive positions #53

Open
1 task done
kunalsingh23 opened this issue Sep 26, 2024 · 0 comments
Open
1 task done

[FEATURE REQ] PFR_IDs for OL / defensive positions #53

kunalsingh23 opened this issue Sep 26, 2024 · 0 comments

Comments

@kunalsingh23
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Would love to be able to connect gsis_id's with pfr_ids. The one mututal connection (which works a lot of the time) is going between rosters <> snap counts tables. Rosters has both gsis and pfr_id which I believe is the only table that does. Once we can connect the gsis, it's easy to get all the other sources.

Describe the solution you'd like

I'm not sure why exactly they are missing, I'm guessing faulty join's on the backend? Mostly missing for OL players, but some defensive players that do have sports ref IDs. There are some (now) significant placers that get a few touches a game that don't have the IDs linked, like Carson Steele.

Example: https://www.pro-football-reference.com/players/W/WyliAn00.htm

Describe alternatives you've considered

Isn't a fault, everything generally works but I don't get all the players in my joins if I'm building things off the snap counts file.

Additional context

nflreadr::load_rosters() %>%
filter(is.na(pfr_id)) %>%
select(position) %>%
table()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant