Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Displayed IRIs in Swate still incorrect #537

Closed
Hannah-Doerpholz opened this issue Oct 17, 2024 · 3 comments
Closed

[BUG] Displayed IRIs in Swate still incorrect #537

Hannah-Doerpholz opened this issue Oct 17, 2024 · 3 comments
Assignees
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@Hannah-Doerpholz
Copy link

Describe the bug
When I search for terms (e.g. extraction buffer, a DPBO term), and I want to click the link I still get an error message. When I check the URL, I see that there are still the purl.obolibrary.org links used, instead of the purl.org links. The same is true for other ontologies such as EFO for example, that don't use obolibrary purls.

To Reproduce
Steps to reproduce the behavior:

  1. Open Swate: https://swate-alpha.nfdi4plants.org/
  2. Open the right-hand menu and go to Ontology term search
  3. Type in either extraction buffer (DPBO:0000050) or family relationship (EFO:0004424)
  4. Click on the term link

Expected behavior
For extraction buffer I expected to be lead to the URL http://purl.org/nfdi4plants/ontology/dpbo/DPBO_0000050
For family relationship I expected to be lead to the URL http://www.ebi.ac.uk/efo/EFO_0004424

Related issues/PRs
This was previously discussion in issue nfdi4plants/ARCtrl#368
The corresponding PR from that time is nfdi4plants/ARCtrl#381

OS and framework information (please complete the following information):

  • OS: Ubuntu 22.04
  • Browser: Firefox

Additional context
Currently (17.10.2024) the internet archive is still under attack which hosts the "expected" purls (purl.org), so ATM none of the expected DPBO links should work until that is resolved.

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 17, 2024
@HLWeil HLWeil added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Oct 18, 2024
@HLWeil HLWeil self-assigned this Oct 18, 2024
@HLWeil
Copy link
Member

HLWeil commented Oct 18, 2024

Hey @Hannah-Doerpholz, thanks for bringing this up.

I checked ARCtrl and this should be fixed.

#r "nuget: ARCtrl, 2.1.0-alpha.4"

open ARCtrl

let efoOA = OntologyAnnotation(tan = "EFO:0004424")

efoOA.TermAccessionOntobeeUrl

let dpboOA = OntologyAnnotation(tan = "DPBO:0000050")

dpboOA.TermAccessionOntobeeUrl

returns

val it: string = "https://bioregistry.io/EFO:0004424"
val it: string = "http://purl.org/nfdi4plants/ontology/dpbo/DPBO_0000050"

First glance this looks like it's not updated in Swate yet @Freymaurer?

@Freymaurer
Copy link
Collaborator

Have to check, will transfer to Swate for now

@Freymaurer Freymaurer transferred this issue from nfdi4plants/ARCtrl Oct 18, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 18, 2024
@Freymaurer Freymaurer removed the Status: Needs Triage This item is up for investigation. label Oct 18, 2024
@Freymaurer
Copy link
Collaborator

Yes this was an oversight on my side. I was still using a pre ARCtrl function, therefore it did not update automatically. Should be fixed now 😞 🐛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: Done
Development

No branches or pull requests

3 participants