Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in ARC specification re workflows? #125

Closed
UrsulaE opened this issue Oct 24, 2024 · 4 comments
Closed

Inconsistency in ARC specification re workflows? #125

UrsulaE opened this issue Oct 24, 2024 · 4 comments
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@UrsulaE
Copy link

UrsulaE commented Oct 24, 2024

Only a small issue, if it is one, but it might lead to unnecessary confusion in the ARC validation, assuming both sentences refer to the same run description file:

Under caption "High-Level Schema" it reads "[Each top-level runs subdirectory (?)] MUST be accompanied by a per-run CWL workflow description, stored in <run_name>.cwl as further described below."

In the "below", it reads "Each such subdirectory MUST contain a workflow description run.cwl, given..."

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 24, 2024
@kMutagene
Copy link
Member

cc @caroott @HLWeil

@HLWeil
Copy link
Member

HLWeil commented Oct 29, 2024

Hey @UrsulaE, thanks for the issue. Will fix this, to be consistent with the other files, i.e. run.cwl without the name of the run.

@HLWeil HLWeil added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Oct 29, 2024
@HLWeil
Copy link
Member

HLWeil commented Oct 29, 2024

fixed in 1635955 and will be part of next release

@HLWeil HLWeil closed this as completed Oct 29, 2024
@github-project-automation github-project-automation bot moved this to Done in ARCStack Oct 29, 2024
@UrsulaE
Copy link
Author

UrsulaE commented Oct 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: Done
Development

No branches or pull requests

3 participants