-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add how to supply ext args with params #2832
Add how to supply ext args with params #2832
Conversation
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nf-core-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sites/docs/src/content/docs/tutorials/tests_and_test_data/nf-test_writing_tests.md
Show resolved
Hide resolved
And should add mention of this in teh modules specs |
…est_writing_tests.md Co-authored-by: James A. Fellows Yates <[email protected]>
7423179
to
d3201e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I just add a small suggestion
Co-authored-by: Jose Espinosa-Carrasco <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to finish a review, sorry @mahesh-panchal
} | ||
``` | ||
|
||
```groovy title="nextflow.config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say nothing else should go in this file?
Also I think there is a broken code block somewhere earlier in this poage, the syntax highlight is off here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added something, although I don't think it's really necessary.
The syntax highlighting looked OK to me. Can you describe what's off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, OK. I think I found it around line 184. I'll see if it fixes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something I don't understand on Line 193 now that changes formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mashehu Any idea why the highlighting goes funny on Line 196?
90ebd15
to
a87aadf
Compare
3b0faf8
to
bae7d2c
Compare
…ore-website into nftest_config_advice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome idea. I think it'll help cut down on the "where did that come from?" feeling of the tests.
More importantly do we have an issue to create linting around this?
what exactly should we lint for? |
A single |
@mahesh-panchal you can merge in now, unless you want to wait for the linting test |
Add description to website how to use params to supply nextflow config in modules nf-core/modules#6788
@netlify /docs/tutorials/tests_and_test_data/nf-test_writing_tests