Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move local modules and subworkflows to tool/main.nf #1080

Closed
adamrtalbot opened this issue Oct 3, 2023 · 1 comment · Fixed by #1083
Closed

Move local modules and subworkflows to tool/main.nf #1080

adamrtalbot opened this issue Oct 3, 2023 · 1 comment · Fixed by #1083
Milestone

Comments

@adamrtalbot
Copy link
Contributor

Description of feature

In an effort to prepare everything for nf-test, we should move each local module or subworkflow .nf file to a named subfolder with main.nf file. This will make it easier to handle importing.

adamrtalbot added a commit that referenced this issue Oct 5, 2023
Changes:
 - Moves every local module into a named subfolder
 - Each module uses a main.nf file
 - Improves consistency between modules (local and nf-core)
 - Should make it easier to create nf-tests

Fixes #1080

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/rnaseq _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] Make sure your code lints (`nf-core lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir \u003cOUTDIR\u003e`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
- [ ] `README.md` is updated (including new tool citations and authors/contributors).
@drpatelh drpatelh added this to the 3.12.1 milestone Oct 15, 2023
@drpatelh
Copy link
Member

Fixed in #1083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants