Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phaseimpute first release (v1.0.0) #142

Open
wants to merge 1,098 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1098 commits
Select commit Hold shift + click to select a range
8684f31
Add check for all imputation tools
LouisLeNezet Jun 13, 2024
b81c002
Update snapshot
LouisLeNezet Jun 13, 2024
8964fe2
Set yml to 2 indent
LouisLeNezet Jun 13, 2024
20956e6
Merge pull request #88 from LouisLeNezet/multiqc
LouisLeNezet Jun 17, 2024
ad09829
Add header to samtools coverage stub
Jun 7, 2024
0127933
Add script and update metromap
Jun 7, 2024
1c0d5b2
Add freq parameter and fix phasing
LouisLeNezet Jun 5, 2024
f820a43
Add patch shapeit5
Jun 5, 2024
1a367f5
Fix linting
Jun 5, 2024
028773f
Fix chunk generation
Jun 5, 2024
a6c1f91
Update main.nf
LouisLeNezet Jun 6, 2024
277cee5
Reverse modification
LouisLeNezet Jun 6, 2024
3e3b140
Add panelprep to metromap
Jun 7, 2024
29d6450
Reverse change
Jun 7, 2024
4b154d2
Update documentation
Jun 7, 2024
b996e7e
Add freq parameter and fix phasing
LouisLeNezet Jun 5, 2024
f68f8ef
Add patch shapeit5
Jun 5, 2024
c27c6f2
Fix linting
Jun 5, 2024
57e06a6
Fix chunk generation
Jun 5, 2024
c843cb8
Add parameter sim_by_chr and dinamically publish downsampled file
Jun 7, 2024
53d0a1f
Simplify channels creations
Jun 8, 2024
fef294e
Add freq parameter and fix phasing
LouisLeNezet Jun 5, 2024
870fa07
Add patch shapeit5
Jun 5, 2024
5d281ac
Update metro map
Jun 12, 2024
25116be
Update metro map
LouisLeNezet Jun 13, 2024
0602cf9
Update image and README
Jun 14, 2024
537840e
Update README
Jun 14, 2024
4888c17
Update metro map
LouisLeNezet Jun 17, 2024
5679f7f
Lint modules.json
LouisLeNezet Jun 17, 2024
aadc7b8
Fix merge error
LouisLeNezet Jun 17, 2024
2e46cfa
Ignore more rules for draw io file
LouisLeNezet Jun 17, 2024
78a8c5c
Update Changelog
LouisLeNezet Jun 17, 2024
fc0d8a0
Update nextflow_schema.json
maxulysse Jun 17, 2024
045430a
Merge pull request #91 from LouisLeNezet/doc
LouisLeNezet Jun 17, 2024
55a8d5b
Merge pull request #92 from nf-core/maxulysse-patch-1
LouisLeNezet Jun 17, 2024
f1f6449
add dog config to test panelprep
atrigila Jul 9, 2024
5ddfc92
update changelog
atrigila Jul 9, 2024
59a0da2
Merge pull request #97 from atrigila/add_dog_dataset
atrigila Jul 9, 2024
a342791
Add support for CRAM, check contigs name (#93)
LouisLeNezet Jul 10, 2024
41e311a
Simplify CSV export and posfile usage (#96)
LouisLeNezet Jul 11, 2024
48eb141
Change compute_freq default to false (#101)
LouisLeNezet Jul 11, 2024
930c996
Update all nf-core modules (#100)
LouisLeNezet Jul 12, 2024
4dde6eb
remove unused subworkflow (#105)
atrigila Jul 16, 2024
a05575c
Fix chr name errors (#102)
LouisLeNezet Jul 16, 2024
fa4f103
Update glimpse2_phase gunzip & multiqc (#103)
LouisLeNezet Jul 16, 2024
8632ed3
Update sample sim full (#109)
LouisLeNezet Jul 18, 2024
95d932f
Update path to full sample (#110)
LouisLeNezet Jul 18, 2024
9ac8ddf
change output directory
atrigila Aug 11, 2024
0dae2e3
update docs and changelog
atrigila Aug 17, 2024
8096826
test imputation in dog
atrigila Aug 18, 2024
c9322a0
Nf test for everyone ! (#111)
LouisLeNezet Aug 23, 2024
1128a80
Merge branch 'dev' into add_docs_customization
atrigila Aug 23, 2024
f2823b0
Merge pull request #118 from atrigila/add_docs_customization
atrigila Aug 24, 2024
6c730f7
update dog config tests
atrigila Aug 24, 2024
762d484
add dog test to ci
atrigila Aug 24, 2024
2fbc45c
update changelog
atrigila Aug 24, 2024
f4e9c47
Merge branch 'dev' into test_dog
atrigila Aug 24, 2024
7702b0f
Update conf/test_dog.config
atrigila Aug 31, 2024
f348eda
fix csv
atrigila Aug 31, 2024
e7d34a4
Merge pull request #119 from atrigila/test_dog
atrigila Aug 31, 2024
c836b09
update changelog
atrigila Aug 31, 2024
0832ad1
add pdiff to nf-test
atrigila Aug 31, 2024
04dc761
Merge branch 'dev' into issue_114
atrigila Aug 31, 2024
ddaea17
update nextflow version in ci
atrigila Aug 31, 2024
36037bd
fix linting
atrigila Aug 31, 2024
a2653ed
Merge pull request #117 from atrigila/issue_114
atrigila Oct 10, 2024
c007e41
Nf core template merge 3.0.1 (#128)
LouisLeNezet Oct 11, 2024
87f537c
Important! Template update for nf-core/tools v3.0.2 (#129)
nf-core-bot Oct 11, 2024
0a25c1c
Normalization as optional and publishing improvment (#131)
LouisLeNezet Oct 15, 2024
a746a17
Add animated metro map (#134)
LouisLeNezet Oct 17, 2024
a4f6618
Add batch support (#135)
LouisLeNezet Oct 28, 2024
8fb7bf0
Update all nf-core modules (#139)
LouisLeNezet Oct 28, 2024
252d63a
Update workflows
LouisLeNezet Oct 28, 2024
d2fa7f8
Simplify chromosome number checking
LouisLeNezet Oct 28, 2024
9c1006a
Add error if contigs intersection is empty
LouisLeNezet Oct 28, 2024
a0a673c
Add parameter for max number of chromosomes showed
LouisLeNezet Oct 28, 2024
e9984d1
Add log info
LouisLeNezet Oct 28, 2024
feecec1
Improve logging information
LouisLeNezet Oct 29, 2024
af3d541
Update changelog
LouisLeNezet Oct 29, 2024
35a98f7
Fix error
LouisLeNezet Oct 29, 2024
abd697f
Fix conda environment
LouisLeNezet Oct 29, 2024
e351bb3
Check guidelines for release and add corrections (#132)
atrigila Oct 29, 2024
262290e
Merge pull request #143 from LouisLeNezet/fix_checkchr
atrigila Oct 29, 2024
679f50e
Conda check removed and seed parameters added for QUILT (#146)
LouisLeNezet Oct 29, 2024
a790ca1
Documentation updates (#144)
hemanoel Oct 29, 2024
a9b0824
Update usage.md (#147)
hemanoel Oct 29, 2024
cf6d3a8
Fix workflow dispatch (#148)
LouisLeNezet Oct 30, 2024
0eff9c2
Remove map
LouisLeNezet Oct 30, 2024
116a042
Remove map (#149)
LouisLeNezet Oct 30, 2024
610993e
Fix gstring error
LouisLeNezet Oct 30, 2024
d7ce7bd
Update Changelog
LouisLeNezet Oct 30, 2024
8ae7179
Update Changelog
LouisLeNezet Oct 30, 2024
10985a2
Fix Gstring interpolation in getFileExtension (#151)
LouisLeNezet Oct 30, 2024
70e24ec
Fix URLs and simplify citation (#152)
LouisLeNezet Oct 30, 2024
22559e7
Simplify getFileExtension
LouisLeNezet Oct 31, 2024
94befe0
Deactivate features in fulltest
LouisLeNezet Oct 31, 2024
849c055
Merge branch 'simplify_filename' into fulltest
LouisLeNezet Oct 31, 2024
33375b3
Fix nf-test of stitch sbwf
LouisLeNezet Oct 31, 2024
92dc6fd
Change nf-test
LouisLeNezet Oct 31, 2024
640d11a
Fix snapshot
LouisLeNezet Oct 31, 2024
b45b139
Fix linting
LouisLeNezet Oct 31, 2024
fe2213c
use correct image link
mashehu Nov 5, 2024
1134498
update nf-test version
atrigila Nov 5, 2024
f28ccb2
Fix link in usage.md
LouisLeNezet Nov 5, 2024
def5bef
Change main figure in table to figure+caption
atrigila Nov 5, 2024
7a4d516
add file titles
atrigila Nov 5, 2024
07bd474
replace table with figures for ordered list
atrigila Nov 5, 2024
13237e3
Order tools alphabetically based on the tool name
atrigila Nov 5, 2024
3e104a8
add useful info from development.md to CONTRIBUTING.md
atrigila Nov 5, 2024
2b3651a
remove logo.svg not used
atrigila Nov 5, 2024
4037e8e
fix typo
atrigila Nov 5, 2024
213ffbf
Fix typos
atrigila Nov 5, 2024
d8d6dff
add tree structure
atrigila Nov 5, 2024
11b0cd3
one line per sentence in markdown
atrigila Nov 5, 2024
ad0eda4
consistent VCF vs. vcf
atrigila Nov 5, 2024
dde1285
add dots to sentences
atrigila Nov 5, 2024
6daae70
remove duplicate
atrigila Nov 5, 2024
fbfa9d0
show example for 3 files
atrigila Nov 5, 2024
13f7611
improve description
atrigila Nov 5, 2024
8779a19
improve usage.md
atrigila Nov 5, 2024
d3844b3
Update language server
Nov 6, 2024
d8ee2b7
Remove input from input initialisation
Nov 6, 2024
eb5ef67
Update changelog
Nov 6, 2024
98dba2a
Fix numbering batch
Nov 6, 2024
1dd253a
Update nf-test modules
Nov 6, 2024
d12bca6
Fix fulltest
Nov 6, 2024
85f3753
Update nf-test
Nov 6, 2024
c2a59ff
Update nf-test
Nov 6, 2024
01a51d0
Update nf-test
Nov 6, 2024
0d20965
Remove .view()
Nov 6, 2024
bbc99d7
Set resourceLimits
Nov 6, 2024
ebf7f9e
Fix region processed with subset
Nov 6, 2024
c7af9b8
Set resourceLimits
Nov 6, 2024
5f86447
Update nf-test
Nov 6, 2024
ed26114
change how to install nf-test
atrigila Nov 6, 2024
af00b5c
remove tsv that is not produced anymore
atrigila Nov 6, 2024
d9cce4a
remove repeated information
atrigila Nov 6, 2024
69eb8bb
give higher level heading to tools, fix grammar
atrigila Nov 6, 2024
17c4817
add groovylang
atrigila Nov 6, 2024
93f51ca
delete tags.yml
atrigila Nov 6, 2024
13d2a2d
align
atrigila Nov 6, 2024
b65f85b
fix patterns in schema
atrigila Nov 6, 2024
c159855
revert setup nf-test
atrigila Nov 6, 2024
e5e4818
test sharding strategy in ci
atrigila Nov 6, 2024
6654bc1
Revert "test sharding strategy in ci"
atrigila Nov 6, 2024
9923c93
make contributing.md same as template
atrigila Nov 6, 2024
a1cd930
fix typo in chrX chr39
atrigila Nov 6, 2024
9f814d8
Update nf-test
LouisLeNezet Nov 7, 2024
9400b16
Fix function validateInputBatchTools
LouisLeNezet Nov 7, 2024
55dc003
Add null return
LouisLeNezet Nov 7, 2024
1527591
Remove println
Nov 7, 2024
ca6c5a5
Update CHANGELOG
Nov 7, 2024
e92e2da
pattern checking for comma separated list
atrigila Nov 8, 2024
b806079
reorganize diagrams in usage section
atrigila Nov 8, 2024
2228cc3
replace for quick working example
atrigila Nov 8, 2024
0c5cdf2
remove txt2image
atrigila Nov 8, 2024
2ba8c89
Set params.chunk_model
LouisLeNezet Nov 8, 2024
0722f8b
Fix linting
LouisLeNezet Nov 8, 2024
7d242be
Update Changelog
Nov 8, 2024
53a7173
Set back fulltest to glimpse1
Nov 8, 2024
25cfc4c
Merge branch 'dev' into chunk_model
LouisLeNezet Nov 8, 2024
80c9d35
Set chunk window size to 4mb
Nov 8, 2024
4f9da30
update image with white background
atrigila Nov 10, 2024
969af5e
improve introduction flow
atrigila Nov 10, 2024
f722171
use setup nf-test
atrigila Nov 10, 2024
857772d
Change chunk model initialisation
Nov 10, 2024
05397b4
Update nextflow_schema.json
atrigila Nov 10, 2024
e34c5a2
Add nf-test for chunk model
Nov 10, 2024
ee27981
Reduce spec of PR
Nov 10, 2024
06d6b60
Merge pull request #157 from LouisLeNezet/chunk_model
LouisLeNezet Nov 10, 2024
4f4d034
remove spaces
atrigila Nov 10, 2024
4e7255e
Merge branch 'adress_review_comments' of https://github.com/atrigila/…
atrigila Nov 10, 2024
3f52128
Merge branch 'dev' into fulltest
LouisLeNezet Nov 10, 2024
200176a
modify diagram
atrigila Nov 10, 2024
10a1dda
Merge pull request #153 from LouisLeNezet/fulltest
LouisLeNezet Nov 11, 2024
f575591
Reduce features of fulltest
Nov 10, 2024
b5e7d91
Update changelog
Nov 11, 2024
01e0927
Check for multiple sample before splitting
Nov 11, 2024
976f2ff
Fix case if empty
LouisLeNezet Nov 12, 2024
2aed82f
Update snapshot phasing sbwf
LouisLeNezet Nov 12, 2024
7222146
Update CHANGELOG
LouisLeNezet Nov 12, 2024
826ca63
Update config
LouisLeNezet Nov 12, 2024
c600724
Add query version
LouisLeNezet Nov 12, 2024
2ca561d
Remove unecessary sbwf inclusion
LouisLeNezet Nov 12, 2024
1512e82
Update changelog and add dependencies
LouisLeNezet Nov 12, 2024
eeb8825
Fix window size
LouisLeNezet Nov 12, 2024
add70ee
Fix name output suffix
LouisLeNezet Nov 12, 2024
50344fe
Update config
Nov 12, 2024
70a3aaf
Fix small naming
Nov 12, 2024
4ff1ed0
Clean multiqc
Nov 12, 2024
e0b8d1b
Update output.md
Nov 12, 2024
2002404
Update nf-test and snapshot
Nov 12, 2024
96258d3
Fix config import order
Nov 12, 2024
b65bfa0
Reset changes
Nov 13, 2024
320ae35
Update pluginsplit
Nov 13, 2024
028f097
Update test
Nov 13, 2024
3c75649
Update changelog and remove bcftools query from config
Nov 13, 2024
1262ef2
Update output.md and remove bcftools query from config
Nov 13, 2024
0a5cb05
Update nf-test sbwf
Nov 13, 2024
0662a58
update diagram
atrigila Nov 17, 2024
da2d16b
Merge pull request #156 from atrigila/adress_review_comments
atrigila Nov 17, 2024
9802306
Update docs/output.md
LouisLeNezet Nov 17, 2024
ae061f6
Merge branch 'dev' into fulltest_only
LouisLeNezet Nov 17, 2024
2e8c39b
Update output and CHANGELOG
Nov 17, 2024
c2a0d0d
Reset changes
Nov 17, 2024
42c5b68
Reset pluginsplit
Nov 17, 2024
a94009a
Fix pluginsplit
Nov 17, 2024
ad643d1
Add back lenient mode in PR
Nov 17, 2024
9d95bad
Change resourceLimits
Nov 17, 2024
3cc9f7a
Set back testquality
Nov 17, 2024
a8e495d
Set to AllSamples.txt
Nov 17, 2024
24b6321
Change resourceLimits
Nov 17, 2024
4e0ce65
Update vcf_split_bcftools
Nov 17, 2024
d299471
Reset VCF_SPLIT_BCFTOOLS
Nov 17, 2024
e63304e
Add chunks size config
Nov 17, 2024
6612290
Update CHANGELOG
Nov 17, 2024
ae4e4fb
Update snapshot
Nov 17, 2024
7abc1f8
Update snapshot
Nov 17, 2024
6c2efb4
Reset change
Nov 17, 2024
e05b8ef
Reset change
Nov 17, 2024
861a0ee
Update snapshot
Nov 17, 2024
baca349
Fix snapshot
Nov 17, 2024
e170511
Improve output organisation
Nov 17, 2024
93bd9ba
Reorder snap
Nov 17, 2024
c8e73e8
Merge pull request #160 from LouisLeNezet/documentation
LouisLeNezet Nov 18, 2024
0e47798
Merge branch 'dev' into fulltest_only
LouisLeNezet Nov 18, 2024
04a12c2
Fix config
LouisLeNezet Nov 18, 2024
8c1fff6
Update pluginsplit
LouisLeNezet Nov 18, 2024
8a7f9a1
Fix splitting operation
LouisLeNezet Nov 18, 2024
7846c23
Fix splitting operation
LouisLeNezet Nov 18, 2024
2eb5f00
Fix splitting operation
LouisLeNezet Nov 18, 2024
a2b15da
Update truth split
Nov 18, 2024
a8600fc
Merge branch 'dev' into config
LouisLeNezet Nov 18, 2024
c1b7f1e
Update snap
Nov 18, 2024
eeb8037
Update bcftools pluginsplit
LouisLeNezet Nov 21, 2024
0bd49f0
Update modules
Nov 22, 2024
c1fd186
Update vcf_split_bcftools
Nov 22, 2024
cd450c3
Add samples renaming for truth splitted files
Nov 22, 2024
2e54095
Reset changes
Nov 22, 2024
ca67cbb
Reset changes
Nov 22, 2024
46464eb
Reset changes
Nov 22, 2024
d3aac0c
Update CHANGELOG
Nov 23, 2024
e58c7e6
Merge pull request #161 from LouisLeNezet/config
LouisLeNezet Nov 23, 2024
6ba6eba
Merge branch 'dev' into fulltest_only
LouisLeNezet Nov 23, 2024
f8c01ac
Update snapshot
Nov 23, 2024
10d95fe
Update snapshot
Nov 23, 2024
69badc3
Merge pull request #158 from LouisLeNezet/fulltest_only
LouisLeNezet Nov 24, 2024
a38adfa
Fix fasta index usage with igenome
LouisLeNezet Nov 25, 2024
aa55dfb
Update CHANGELOG
LouisLeNezet Nov 25, 2024
d092479
Merge pull request #162 from LouisLeNezet/fasta_index
LouisLeNezet Nov 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
20 changes: 20 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"name": "nfcore",
"image": "nfcore/gitpod:latest",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/opt/conda/bin/python"
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
}
}
}
42 changes: 42 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
indent_size = 4
indent_style = space

[*.{md,yml,yaml,html,css,scss,js}]
indent_size = 2

# These files are edited and tested upstream in nf-core/modules
[/modules/nf-core/**]
charset = unset
end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset
[/subworkflows/nf-core/**]
charset = unset
end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset

[/assets/email*]
indent_size = unset

# ignore python and markdown
[*.{py,md}]
indent_style = unset

[/docs/*.xml*]
indent_style = unset
insert_final_newline = unset

[/docs/images/metro/*.xml*]
indent_style = unset
insert_final_newline = unset
end_of_line = unset
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
*.config linguist-language=nextflow
*.nf.test linguist-language=nextflow
modules/nf-core/** linguist-generated
subworkflows/nf-core/** linguist-generated
6 changes: 6 additions & 0 deletions .github/.dockstore.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Dockstore config version, not pipeline version
version: 1.2
workflows:
- subclass: nfl
primaryDescriptorPath: /nextflow.config
publish: True
92 changes: 80 additions & 12 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,35 +9,42 @@ Please use the pre-filled template to save time.
However, don't be put off by this template - other more general issues and suggestions are welcome!
Contributions to the code are even more welcome ;)

> [!NOTE]
> If you need help using or modifying nf-core/phaseimpute then the best place to ask is on the nf-core Slack [#phaseimpute](https://nfcore.slack.com/channels/phaseimpute) channel ([join our Slack here](https://nf-co.re/join/slack)).

## Contribution workflow

If you'd like to write some code for nf-core/phaseimpute, the standard workflow is as follows:

1. Check that there isn't already an issue about your idea in the [nf-core/phaseimpute issues](https://github.com/nf-core/phaseimpute/issues) to avoid duplicating work
* If there isn't one already, please create one so that others know you're working on this
1. Check that there isn't already an issue about your idea in the [nf-core/phaseimpute issues](https://github.com/nf-core/phaseimpute/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/phaseimpute repository](https://github.com/nf-core/phaseimpute) to your GitHub account
3. Make the necessary changes / additions within your forked repository
4. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
4. Use `nf-core pipelines schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged

If you're not used to this workflow with git, you can start with some [docs from GitHub](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests) or even their [excellent `git` resources](https://try.github.io/).

## Tests

You have the option to test your changes locally by running the pipeline. For receiving warnings about process selectors and other `debug` information, it is recommended to use the debug profile. Execute all the tests with the following command:

```bash
nf-test test --profile debug,test,docker --verbose
```

When you create a pull request with changes, [GitHub Actions](https://github.com/features/actions) will run automatic tests.
Typically, pull-requests are only fully reviewed when these tests are passing, though of course we can help out before then.

There are typically two types of tests that run:

### Lint Tests
### Lint tests

`nf-core` has a [set of guidelines](https://nf-co.re/developers/guidelines) which all pipelines must adhere to.
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core lint <pipeline-directory>` command.
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core pipelines lint <pipeline-directory>` command.

If any failures or warnings are encountered, please follow the listed URL for more documentation.

### Pipeline Tests
### Pipeline tests

Each `nf-core` pipeline should be set up with a minimal set of test-data.
`GitHub Actions` then runs the pipeline on this data to ensure that it exits successfully.
Expand All @@ -46,12 +53,73 @@ These tests are run both with the latest available version of `Nextflow` and als

## Patch

: warning: Only in the unlikely and regretful event of a release happening with a bug.
:warning: Only in the unlikely and regretful event of a release happening with a bug.

* On your own fork, make a new branch `patch` based on `upstream/master`.
* Fix the bug, and bump version (X.Y.Z+1).
* A PR should be made on `master` from patch to directly this particular bug.
- On your own fork, make a new branch `patch` based on `upstream/master`.
- Fix the bug, and bump version (X.Y.Z+1).
- A PR should be made on `master` from patch to directly this particular bug.
LouisLeNezet marked this conversation as resolved.
Show resolved Hide resolved

## Getting help

For further information/help, please consult the [nf-core/phaseimpute documentation](https://nf-co.re/nf-core/phaseimpute/docs) and don't hesitate to get in touch on the nf-core Slack [#phaseimpute](https://nfcore.slack.com/channels/phaseimpute) channel ([join our Slack here](https://nf-co.re/join/slack)).
For further information/help, please consult the [nf-core/phaseimpute documentation](https://nf-co.re/phaseimpute/usage) and don't hesitate to get in touch on the nf-core Slack [#phaseimpute](https://nfcore.slack.com/channels/phaseimpute) channel ([join our Slack here](https://nf-co.re/join/slack)).

## Pipeline contribution conventions

To make the nf-core/phaseimpute code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.
LouisLeNezet marked this conversation as resolved.
Show resolved Hide resolved

### Adding a new step

If you wish to contribute a new step, please use the following coding standards:

1. Define the corresponding input channel into your new process from the expected previous process channel
LouisLeNezet marked this conversation as resolved.
Show resolved Hide resolved
2. Write the process block (see below).
3. Define the output channel if needed (see below).
4. Add any new parameters to `nextflow.config` with a default (see below).
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core pipelines schema build` tool).
6. Add sanity checks and validation for all relevant parameters.
7. Perform local tests to validate that the new code works as expected.
8. If applicable, add a new test command in `.github/workflow/ci.yml`.
9. Update MultiQC config `assets/multiqc_config.yml` so relevant suffixes, file name clean up and module plots are in the appropriate order. If applicable, add a [MultiQC](https://https://multiqc.info/) module.
10. Add a description of the output files and if relevant any appropriate images from the MultiQC report to `docs/output.md`.

### Default values

Parameters should be initialised / defined with default values in `nextflow.config` under the `params` scope.
LouisLeNezet marked this conversation as resolved.
Show resolved Hide resolved

Once there, use `nf-core pipelines schema build` to add to `nextflow_schema.json`.

### Default processes resource requirements

Sensible defaults for process resource requirements (CPUs / memory / time) for a process should be defined in `conf/base.config`. These should generally be specified generic with `withLabel:` selectors so they can be shared across multiple processes/steps of the pipeline. A nf-core standard set of labels that should be followed where possible can be seen in the [nf-core pipeline template](https://github.com/nf-core/tools/blob/main/nf_core/pipeline-template/conf/base.config), which has the default process as a single core-process, and then different levels of multi-core configurations for increasingly large memory requirements defined with standardised labels.

The process resources can be passed on to the tool dynamically within the process with the `${task.cpus}` and `${task.memory}` variables in the `script:` block.

### Naming schemes

Please use the following naming schemes, to make it easy to understand what is going where.

- initial process channel: `ch_output_from_<process>`
- intermediate and terminal channels: `ch_<previousprocess>_for_<nextprocess>`

### Nextflow version bumping

If you are using a new feature from core Nextflow, you may bump the minimum required version of nextflow in the pipeline with: `nf-core pipelines bump-version --nextflow . [min-nf-version]`

### Images and figures

For overview images and other documents we follow the nf-core [style guidelines and examples](https://nf-co.re/developers/design_guidelines).

## GitHub Codespaces

This repo includes a devcontainer configuration which will create a GitHub Codespaces for Nextflow development! This is an online developer environment that runs in your browser, complete with VSCode and a terminal.

To get started:

- Open the repo in [Codespaces](https://github.com/nf-core/phaseimpute/codespaces)
- Tools installed
- nf-core
- Nextflow

Devcontainer specs:

- [DevContainer config](.devcontainer/devcontainer.json)
42 changes: 0 additions & 42 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Bug report
description: Report something that is broken or incorrect
labels: bug
body:
- type: markdown
attributes:
value: |
Before you post this issue, please check the documentation:

- [nf-core website: troubleshooting](https://nf-co.re/usage/troubleshooting)
- [nf-core/phaseimpute pipeline documentation](https://nf-co.re/phaseimpute/usage)

- type: textarea
id: description
attributes:
label: Description of the bug
description: A clear and concise description of what the bug is.
validations:
required: true

- type: textarea
id: command_used
attributes:
label: Command used and terminal output
description: Steps to reproduce the behaviour. Please paste the command you used to launch the pipeline and the output from your terminal.
render: console
placeholder: |
$ nextflow run ...

Some output where something broke

- type: textarea
id: files
attributes:
label: Relevant files
description: |
Please drag and drop the relevant files here. Create a `.zip` archive if the extension is not allowed.
Your verbose log file `.nextflow.log` is often useful _(this is a hidden file in the directory where you launched the pipeline)_ as well as custom Nextflow configuration files.

- type: textarea
id: system
attributes:
label: System information
description: |
* Nextflow version _(eg. 23.04.0)_
* Hardware _(eg. HPC, Desktop, Cloud)_
* Executor _(eg. slurm, local, awsbatch)_
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter, Charliecloud, or Apptainer)_
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
* Version of nf-core/phaseimpute _(eg. 1.1, 1.5, 1.8.2)_
7 changes: 7 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
contact_links:
- name: Join nf-core
url: https://nf-co.re/join
about: Please join the nf-core community here
- name: "Slack #phaseimpute channel"
url: https://nfcore.slack.com/channels/phaseimpute
about: Discussion about the nf-core/phaseimpute pipeline
24 changes: 0 additions & 24 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: Feature request
description: Suggest an idea for the nf-core/phaseimpute pipeline
labels: enhancement
body:
- type: textarea
id: description
attributes:
label: Description of feature
description: Please describe your suggestion for a new feature. It might help to describe a problem or use case, plus any alternatives that you have considered.
validations:
required: true
25 changes: 16 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,26 @@
<!--
# nf-core/phaseimpute pull request

Many thanks for contributing to nf-core/phaseimpute!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release.

Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/phaseimpute/tree/master/.github/CONTRIBUTING.md)
-->

## PR checklist

- [ ] This comment contains a description of changes (with reason)
- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If necessary, also make a PR on the [nf-core/phaseimpute branch on the nf-core/test-datasets repo](https://github.com/nf-core/test-datasets/pull/new/nf-core/phaseimpute)
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker`).
- [ ] Make sure your code lints (`nf-core lint .`).
- [ ] Documentation in `docs` is updated
- [ ] `CHANGELOG.md` is updated
- [ ] `README.md` is updated

**Learn more about contributing:** [CONTRIBUTING.md](https://github.com/nf-core/phaseimpute/tree/master/.github/CONTRIBUTING.md)
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/phaseimpute/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/phaseimpute _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] Make sure your code lints (`nf-core pipelines lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
- [ ] `README.md` is updated (including new tool citations and authors/contributors).
5 changes: 0 additions & 5 deletions .github/markdownlint.yml

This file was deleted.

Loading
Loading