Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paper & Update to template 2.11.1 #55

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Add paper & Update to template 2.11.1 #55

merged 9 commits into from
Jan 12, 2024

Conversation

apeltzer
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@apeltzer apeltzer changed the title Add paper Add paper & Update to template 2.11.1 Jan 12, 2024
@apeltzer
Copy link
Member Author

Maybe we'll wait for the upstream NACHO bugfix to be included in 1.2.1 too ... @christopher-mohr / @neslihanky

Copy link

github-actions bot commented Jan 12, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 18436f9

+| ✅ 163 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowNanostring.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-12 16:03:22

README.md Outdated Show resolved Hide resolved
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an easy one

@apeltzer apeltzer merged commit e7c564c into dev Jan 12, 2024
6 checks passed
@apeltzer apeltzer deleted the add-paper branch January 12, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants