Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create gene heatmap nftest #102

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Create gene heatmap nftest #102

merged 4 commits into from
Nov 20, 2024

Conversation

nschcolnicov
Copy link

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 01a4024

+| ✅ 199 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-20 14:32:25

atrigila
atrigila approved these changes Nov 20, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### `Added`

- [#94](https://github.com/nf-core/nanostring/pull/94) - Added nf-tests for local subworkflows normalize and quality_control.
- [#102](https://github.com/nf-core/nanostring/pull/102) - Added nf-tests for local module create_gene_heatmap.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [#102](https://github.com/nf-core/nanostring/pull/102) - Added nf-tests for local module create_gene_heatmap.
- [#102](https://github.com/nf-core/nanostring/pull/102) - Added nf-tests for local module `CREATE_GENE_HEATMAP`.

modules/local/create_gene_heatmap/meta.yml Outdated
- - heatmap_genes_to_filter:
type: file
description: |
"Path to yml file (list, one item per line) to specify which genes should be used for the gene-count heatmap."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Path to yml file (list, one item per line) to specify which genes should be used for the gene-count heatmap."
Path to yml file (list, one item per line) to specify which genes should be used for the gene-count heatmap.

modules/local/create_gene_heatmap/meta.yml Show resolved Hide resolved
@nschcolnicov nschcolnicov merged commit 3e624d4 into dev Nov 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrigila atrigila atrigila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nschcolnicov @atrigila