Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated subworkflows, modules and test snaps #105

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

nschcolnicov
Copy link

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Nov 22, 2024

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 992ad8d

+| ✅ 200 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-22 20:48:07

@nschcolnicov
Copy link
Author

nschcolnicov commented Nov 22, 2024

For some reason snaps don't match between local execution and CI execution whenever MultiQC 1.25.1 is used, I will update everything else and create a separate issue for this as I'm not sure if this is an issue with the pipeline or with MultiQC module.
#108
MultiQC/MultiQC#2984

@nschcolnicov nschcolnicov marked this pull request as ready for review November 25, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant