Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nf-test for arriba/download #6240

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Added nf-test for arriba/download #6240

merged 1 commit into from
Aug 22, 2024

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Aug 22, 2024

PR checklist

Closes #XXX

  • Added nf-test for arriba/download with [FEATURE] Port pytest with --migrate-pytest-hard #6226
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@GallVp GallVp requested a review from a team as a code owner August 22, 2024 05:09
@GallVp GallVp requested review from LeuThrAsp and removed request for a team August 22, 2024 05:09
@SPPearce SPPearce added this pull request to the merge queue Aug 22, 2024
Merged via the queue into nf-core:master with commit a289753 Aug 22, 2024
12 checks passed
@GallVp GallVp deleted the nf-test/arriba_download branch August 22, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

@LeuThrAsp LeuThrAsp Awaiting requested review from LeuThrAsp LeuThrAsp was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GallVp @SPPearce