add paths in output directive in cellranger cout module #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grst
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Given your reasoning in nf-core/scrnaseq#301 (comment), I guess why not. I also doesn't break existing workflows because the outs channel is unmodified.
nvnieuwk
approved these changes
Mar 14, 2024
fmalmeida
added a commit
that referenced
this pull request
Mar 20, 2024
This reverts commit 92ca535.
vlebars
pushed a commit
to vlebars/modules
that referenced
this pull request
Mar 20, 2024
…core#5306) Revert "add paths in output directive in cellranger cout module (nf-core#5108)" This reverts commit 92ca535.
tucano
pushed a commit
to tucano/modules
that referenced
this pull request
Mar 20, 2024
* add paths in output directive * update meta.yml * add stub file generation * also create fake files in new stub * update stub snaps as new output channels are now emitted
tucano
pushed a commit
to tucano/modules
that referenced
this pull request
Mar 20, 2024
…core#5306) Revert "add paths in output directive in cellranger cout module (nf-core#5108)" This reverts commit 92ca535.
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
* add paths in output directive * update meta.yml * add stub file generation * also create fake files in new stub * update stub snaps as new output channels are now emitted
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
…core#5306) Revert "add paths in output directive in cellranger cout module (nf-core#5108)" This reverts commit 92ca535.
alexnater
pushed a commit
to alexnater/nf-core-modules
that referenced
this pull request
Mar 21, 2024
* add paths in output directive * update meta.yml * add stub file generation * also create fake files in new stub * update stub snaps as new output channels are now emitted
alexnater
pushed a commit
to alexnater/nf-core-modules
that referenced
this pull request
Mar 21, 2024
…core#5306) Revert "add paths in output directive in cellranger cout module (nf-core#5108)" This reverts commit 92ca535.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update relates to requirement for PR in
nf-core/scrnaseq: nf-core/scrnaseq#301