Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nextflow_schema.json structure #279

Merged
merged 5 commits into from
Oct 26, 2024
Merged

fix nextflow_schema.json structure #279

merged 5 commits into from
Oct 26, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 23, 2024

Just guessed the section to put it in.
This parameter needs some documentation.

@mashehu mashehu requested a review from a team as a code owner October 23, 2024 11:56
@mashehu mashehu requested review from Aratz and removed request for a team October 23, 2024 11:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 320037a

+| ✅ 202 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.5.2
  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-24 15:13:17

@grst
Copy link
Member

grst commented Oct 24, 2024

The "strandedness" is only used for downstream samplesheet generation, e.g. to specify strandedness for the nf-core/rnaseq samplesheet that is generated. It has no effect on the demux result.

@mashehu
Copy link
Contributor Author

mashehu commented Oct 24, 2024

feel free to put it in the right section 🙂

mashehu
mashehu commented Oct 24, 2024
View reviewed changes
nextflow_schema.json Outdated Show resolved Hide resolved
@nschcolnicov nschcolnicov self-requested a review October 25, 2024 14:13
nschcolnicov
nschcolnicov approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@nschcolnicov nschcolnicov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atrigila atrigila merged commit 9e11c07 into dev Oct 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschcolnicov nschcolnicov nschcolnicov approved these changes

@Aratz Aratz Awaiting requested review from Aratz Aratz is a code owner automatically assigned from nf-core/demultiplex

Assignees

@atrigila atrigila

@nschcolnicov nschcolnicov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mashehu @grst @nschcolnicov @atrigila