Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.11 #162

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Important! Template update for nf-core/tools v2.11 #162

merged 3 commits into from
Dec 20, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.11 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.11 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.11 release page.

@nf-core-bot nf-core-bot requested a review from a team as a code owner December 19, 2023 19:03
@nf-core-bot nf-core-bot requested review from kobelavaerts and removed request for a team December 19, 2023 19:03
@Aratz Aratz self-assigned this Dec 20, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 455dfaa

+| ✅ 160 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowDemultiplex.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.11
  • Run at 2023-12-20 08:06:31

@Aratz Aratz force-pushed the nf-core-template-merge-2.11 branch from cd9f577 to 455dfaa Compare December 20, 2023 08:05
edmundmiller
edmundmiller approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking care of that!

docs/usage.md
@@ -18,7 +18,7 @@ When using the demultiplexer fqtk, the samplesheet must contain an additional co

### Full samplesheet

```console
```csv title="samplesheet.csv"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did GitHub add this?!? Love it!

@edmundmiller edmundmiller merged commit 593047f into dev Dec 20, 2023
7 checks passed
@edmundmiller edmundmiller deleted the nf-core-template-merge-2.11 branch December 20, 2023 14:53
@maxulysse
Copy link
Member

Add .nf-test to .prettierignore

I knew I forgot to add something to TEMPLATE

@Aratz Aratz mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@kobelavaerts kobelavaerts Awaiting requested review from kobelavaerts kobelavaerts is a code owner automatically assigned from nf-core/demultiplex

@maxulysse maxulysse Awaiting requested review from maxulysse

@mashehu mashehu Awaiting requested review from mashehu

Assignees

@Aratz Aratz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nf-core-bot @maxulysse @edmundmiller @Aratz