Release candidate 1.4.0 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add singularity.registry = 'quay.io' and bump NF version to 23.04.0
Fix/ci nf tests & Remove un-necessary registry declarations
Remove_aws_ecr_public_profile
Need to work out the required part. I wonder if we can have different schemas depending on the demultiplexer. #138
Co-authored-by: matthdsm <[email protected]>
Co-authored-by: maxulysse <[email protected]>
As seen in `workflows/demultiplex.nf`, when neither trimming nor fastq are skipped, md5 sums will only be generated for fastp files.
RunInfo.xml is not an output file of bclconvert nor bcl2fastq, it is generated by the instrument.
Fix `bcl2fastq` and `bclconvert` publishDir
Fixes #156
Co-authored-by: aratz <[email protected]>
Update all modules
Set publish mode for FastQs
Ran `nf-core bump-version 1.4.0`
Co-authored-by: Maxime U Garcia <[email protected]>
Pre-release v1.4.0
Aratz
requested review from
nh13,
sam-white04,
blajoie,
matthdsm and
edmundmiller
as code owners
|
maxulysse
reviewed
Dec 14, 2023
| - name: Run nf-test | ||
| run: nf-test test --profile=test,${{ matrix.profile }} tests/${{ matrix.component }}/${{ matrix.tags }}/*.nf.test --junitxml=${{ matrix.tags }}.xml | ||
| run: nf-test test tests/pipeline/ --profile=test,${{ matrix.profile }} --junitxml=test.xml |
There was a problem hiding this comment.
I feel like using tag would be more efficient, but good enough for me
There was a problem hiding this comment.
It was written pre-tags 😉
maxulysse
reviewed
Dec 14, 2023
| @@ -25,11 +25,11 @@ | |||
| "minimum": 1, | |||
| "maximum": 8 | |||
| }, | |||
| "run_dir": { | |||
There was a problem hiding this comment.
I don't think we're using from_samlesheet yet, so this won't matter until #102
edmundmiller
approved these changes
Dec 14, 2023
| - name: Run nf-test | ||
| run: nf-test test --profile=test,${{ matrix.profile }} tests/${{ matrix.component }}/${{ matrix.tags }}/*.nf.test --junitxml=${{ matrix.tags }}.xml | ||
| run: nf-test test tests/pipeline/ --profile=test,${{ matrix.profile }} --junitxml=test.xml |
There was a problem hiding this comment.
It was written pre-tags 😉
| @@ -25,11 +25,11 @@ | |||
| "minimum": 1, | |||
| "maximum": 8 | |||
| }, | |||
| "run_dir": { | |||
There was a problem hiding this comment.
I don't think we're using from_samlesheet yet, so this won't matter until #102
maxulysse
approved these changes
Dec 14, 2023
|
Thanks a lot @Aratz <3 |
glichtenstein
added a commit
to glichtenstein/demultiplex
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release candidate for v1.4.0
Includes the following:
AddedChangedFixedsingularity.registry = 'quay.io'and bump NF version to 23.04.0Removedpublic_aws_ecrprofile.