Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using start and end instead of left and right to support RTL in the calendar. #4007

Open
darkyeg opened this issue Nov 7, 2024 · 2 comments
Open

Using start and end instead of left and right to support RTL in the calendar. #4007

darkyeg opened this issue Nov 7, 2024 · 2 comments

Comments

@darkyeg
Copy link

darkyeg commented Nov 7, 2024

nextui/packages/core/theme/src/components/calendar.ts

Lines 91 to 96 in 1091377

"data-[range-start=true]:before:rounded-l-full",
"data-[selection-start=true]:before:rounded-l-full",
// end (pseudo)
"data-[range-end=true]:before:rounded-r-full",
"data-[selection-end=true]:before:rounded-r-full",

@linear Linear
Copy link

linear bot commented Nov 7, 2024

ENG-1528 "Use `start` and `end` instead of `left` and `right` to support RTL."

@darkyeg darkyeg changed the title "Use start and end instead of left and right to support RTL." Using start and end instead of left and right to support RTL in the calendar. Nov 7, 2024
@RadheyMugdal
Copy link

I’m interested in working on this issue. Would it be okay if I submitted a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darkyeg @RadheyMugdal