Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: search Input width in navbar docs #3771

Open
erikdemarco opened this issue Sep 17, 2024 · 12 comments · May be fixed by #3867
Open

enhancement: search Input width in navbar docs #3771

erikdemarco opened this issue Sep 17, 2024 · 12 comments · May be fixed by #3867
Assignees
Labels
📋 Scope : Docs Related to the documentation ✨ Type: Enhancement New enhancement on existing codebase

Comments

@erikdemarco
Copy link

Is your feature request related to a problem? Please describe.

I like nextui, but it seems the developer just use this as a fun project and not serious about it.

For example when you see:
https://nextui.org/docs/components/navbar#with-search-input

Then if you try modify the width, the search input looks so ugly when viewed in mobile width. It gives an impression that this example put there just to quickly finish the docs, dont care how it looks on mobile.

Describe the solution you'd like

please rewrite the "With Search Input" part in navbar docs

Describe alternatives you've considered

please rewrite the "With Search Input" part in navbar docs

Screenshots or Videos

Screenshot_2024-09-17_10-57-40

Copy link

linear bot commented Sep 17, 2024

@wingkwong wingkwong added ✨ Type: Enhancement New enhancement on existing codebase 📋 Scope : Docs Related to the documentation labels Sep 17, 2024
@wingkwong wingkwong changed the title [Feature Request] Rewrite Search Input in navbar docs... enhancement: search Input width in navbar docs Sep 17, 2024
@successbyte
Copy link

Hi community, I am interested in this issue would you please assign it to me.

@wingkwong
Copy link
Member

@successbyte assigned

@wingkwong
Copy link
Member

@successbyte any update?

@successbyte
Copy link

successbyte commented Sep 28, 2024

Hi @wingkwong I am working on it please give me more time
had a problem on running docs
thanks

@successbyte
Copy link

Hi @wingkwong
as the bellow picture all docs run good but the components are not working
could you please guide me
and I tried all contributing.md guidelines

next

@wingkwong
Copy link
Member

looks fine on my side

image

@successbyte
Copy link

great
I'm not gonna give up 😄
give me a little time
trying on another laptop to se if it work

@alexnguyennz
Copy link
Contributor

Might be related to line endings. I had the same issue, had to save the main mdx file e.g. navbar.mdx with LF instead of CLRF.

@successbyte
Copy link

Hey @alexnguyennz you saved my life
It worked thanks man.
now I'm solving the issue

@successbyte
Copy link

Hi @wingkwong
finally I succeeded at running the project

  • lost 750GB data 😄 and partitioned the drives
  • I tried on 4 windows machines it did not work for me
  • installed Ubuntu and it worked

anyway, do you want me to set min width to the input in small sizes?

and one thing thanks to gave me the chance (time)

@successbyte
Copy link

successbyte commented Oct 10, 2024

The changes I made to input I think it's good
please confirm to make PR

For large screens:

Screenshot from 2024-10-10 22-20-37

For small screens:

Screenshot from 2024-10-10 22-21-41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 Scope : Docs Related to the documentation ✨ Type: Enhancement New enhancement on existing codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants