-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tempdirectory (and maybe more in config.php defined folders) should be excluded from the check of extra files #227
Comments
While upgrading to 15.0.7 i ran in that issue as well. The updater pre-check stopped because of the unexpected extra folder 'tmp'. After having finished the upgrade the missing tmp folder was reported in the logging ;) |
As a workaround I moved the tmp folder outside the nextcloud
installation folder. This message should never come again ;)
|
Hey, |
I don't agree with you. If you put the tmp directory inside document root it's reachable from the web (sure you can deny access to it) but the right way is to put it outside the document root. |
cc @MorrisJobke sounds like a nice feature but demand ... |
The |
* Addresses nextcloud/updater#227 * Addresses nextcloud/updater#113 If one decides to use the `tempdirectory` override, this recommends it be placed outside the NC installation directory (to clear unexpected file checks) as well as outside the document root (for security reasons). Signed-off-by: Josh Richards <[email protected]>
Is your feature request related to a problem? Please describe.
When updating Nextcloud:
Check for expected files
The following extra files have been found:
tmp
This folder is defined via
'tempdirectory' => '/www/htdocs/cloud/tmp',
Describe the solution you'd like
tempdirectory (and maybe more in config.php defined folders) should be excluded from the check of extra files
The text was updated successfully, but these errors were encountered: