Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tempdirectory (and maybe more in config.php defined folders) should be excluded from the check of extra files #227

Closed
eisenherzz opened this issue Apr 5, 2019 · 7 comments

Comments

@eisenherzz
Copy link

Is your feature request related to a problem? Please describe.
When updating Nextcloud:
Check for expected files
The following extra files have been found:
tmp
This folder is defined via 'tempdirectory' => '/www/htdocs/cloud/tmp',

Describe the solution you'd like
tempdirectory (and maybe more in config.php defined folders) should be excluded from the check of extra files

@yafp
Copy link

yafp commented Apr 10, 2019

While upgrading to 15.0.7 i ran in that issue as well. The updater pre-check stopped because of the unexpected extra folder 'tmp'.
Removing that folder helped executing the upgrade.

After having finished the upgrade the missing tmp folder was reported in the logging ;)

@eisenherzz
Copy link
Author

eisenherzz commented Apr 10, 2019 via email

@yafp
Copy link

yafp commented Apr 11, 2019

Hey,
sounds like a possible workaround while i still think the problem should be properly solved ;)

@kesselb
Copy link
Contributor

kesselb commented Apr 11, 2019

Hey,
sounds like a possible workaround while i still think the problem should be properly solved ;)

I don't agree with you. If you put the tmp directory inside document root it's reachable from the web (sure you can deny access to it) but the right way is to put it outside the document root.

@kesselb
Copy link
Contributor

kesselb commented Jun 10, 2019

cc @MorrisJobke sounds like a nice feature but demand ...

@MorrisJobke MorrisJobke transferred this issue from nextcloud/server Jul 3, 2019
@joshtrichards
Copy link
Member

The tempdirectory parameter is only mentioned in two places in the Admin Manual. I think we should just cover this in the docs with a note that if you customize this parameter, it shouldn't be located in the NC install directory. This documents best practice. If people still want to do it, that's on them. :-)

@joshtrichards
Copy link
Member

joshtrichards commented Jun 18, 2023

Duplicate of #68 & #113

joshtrichards added a commit to joshtrichards/nc-server that referenced this issue Jun 18, 2023
* Addresses nextcloud/updater#227
* Addresses nextcloud/updater#113

If one decides to use the `tempdirectory` override, this recommends it be placed outside the NC installation directory (to clear unexpected file checks) as well as outside the document root (for security reasons).

Signed-off-by: Josh Richards <[email protected]>
@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants