Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle version restore #4785

Open
juliusknorr opened this issue Sep 9, 2023 · 2 comments
Open

Gracefully handle version restore #4785

juliusknorr opened this issue Sep 9, 2023 · 2 comments
Labels
1. to develop enhancement New feature or request feature: conflict resolution

Comments

@juliusknorr
Copy link
Member

When restoring a version through the web UI we should make sure to handle this without a conflict.

Similar how nextcloud/richdocuments#3152 does this, we can use the events to detect the restore from nextcloud/server#40184
@juliusknorr juliusknorr added enhancement New feature or request 1. to develop labels Sep 9, 2023
@luka-nextcloud
Copy link
Contributor

My suggestion is reusing (and some modify) component CollisionResolveDialog to handle the version restoring action.

@juliusknorr
Copy link
Member Author

The conflict dialog should already appear as the file is changed on the backend, but my idea was to skip that and resolve automatically as the restore is already a decition the user makes to overwrite the file content.

We should:

  • Make sure we somehow notify other users about the restore
  • Just apply the change without showing the conflict dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop enhancement New feature or request feature: conflict resolution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshtrichards @juliusknorr @luka-nextcloud