From 56ff2a79f7bb7ff37b0db4beaa87ca690397d3d8 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Thu, 27 Jun 2024 14:47:48 +0200 Subject: [PATCH] perf: optimize WorkspaceService::getFile Signed-off-by: Robin Appelman --- lib/Service/WorkspaceService.php | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/Service/WorkspaceService.php b/lib/Service/WorkspaceService.php index 988b04fc6c9..8ffa11a06ef 100644 --- a/lib/Service/WorkspaceService.php +++ b/lib/Service/WorkspaceService.php @@ -24,15 +24,13 @@ public function __construct(IL10N $l10n) { public function getFile(Folder $folder): ?File { foreach ($this->getSupportedFilenames() as $filename) { - if ($folder->nodeExists($filename)) { - try { - $file = $folder->get($filename); - if ($file instanceof File) { - return $file; - } - } catch (NotFoundException|StorageInvalidException) { - return null; + try { + $file = $folder->get($filename); + if ($file instanceof File) { + return $file; } + } catch (NotFoundException|StorageInvalidException) { + continue; } } return null;