From aa57529b54c4e9b6e4780a502d683664bc162537 Mon Sep 17 00:00:00 2001 From: Maksim Sukharev Date: Mon, 29 Jul 2024 14:17:23 +0200 Subject: [PATCH 1/5] chore(deps): bump @nextcloud/vue library from 8.15.0 to 8.15.1 Signed-off-by: Maksim Sukharev --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index a4f61efcdc7..b611072ab42 100644 --- a/package-lock.json +++ b/package-lock.json @@ -23,7 +23,7 @@ "@nextcloud/paths": "^2.2.1", "@nextcloud/router": "^3.0.1", "@nextcloud/upload": "^1.4.2", - "@nextcloud/vue": "^8.15.0", + "@nextcloud/vue": "^8.15.1", "@vueuse/components": "^10.11.0", "crypto-js": "^4.2.0", "debounce": "^2.1.0", @@ -3868,9 +3868,9 @@ } }, "node_modules/@nextcloud/vue": { - "version": "8.15.0", - "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.15.0.tgz", - "integrity": "sha512-Yxf7bIzKV3vCDJDZo99dSLpfe9wMh0hTvmlov5B8V+ZX/foq+O/EcvPivbJmesjIi6LKg+z4K53d7tU2izAPSg==", + "version": "8.15.1", + "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.15.1.tgz", + "integrity": "sha512-gZEcXPNhRGYhjSd/IeTs0jQ5P8tPIv9BJm5A8qsdpB1Mb/Xb9suhJv1xHaeGcOGoUCcs7A66coPkCgv1zcSJ2w==", "dependencies": { "@floating-ui/dom": "^1.1.0", "@linusborg/vue-simple-portal": "^0.1.5", @@ -23621,9 +23621,9 @@ } }, "@nextcloud/vue": { - "version": "8.15.0", - "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.15.0.tgz", - "integrity": "sha512-Yxf7bIzKV3vCDJDZo99dSLpfe9wMh0hTvmlov5B8V+ZX/foq+O/EcvPivbJmesjIi6LKg+z4K53d7tU2izAPSg==", + "version": "8.15.1", + "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.15.1.tgz", + "integrity": "sha512-gZEcXPNhRGYhjSd/IeTs0jQ5P8tPIv9BJm5A8qsdpB1Mb/Xb9suhJv1xHaeGcOGoUCcs7A66coPkCgv1zcSJ2w==", "requires": { "@floating-ui/dom": "^1.1.0", "@linusborg/vue-simple-portal": "^0.1.5", diff --git a/package.json b/package.json index 3334f091a66..ed88d2c910c 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ "@nextcloud/paths": "^2.2.1", "@nextcloud/router": "^3.0.1", "@nextcloud/upload": "^1.4.2", - "@nextcloud/vue": "^8.15.0", + "@nextcloud/vue": "^8.15.1", "@vueuse/components": "^10.11.0", "crypto-js": "^4.2.0", "debounce": "^2.1.0", From 12ec9babcb3f3bef763db380bfc1c32ab271f947 Mon Sep 17 00:00:00 2001 From: Maksim Sukharev Date: Thu, 25 Jul 2024 10:27:15 +0200 Subject: [PATCH 2/5] fix(Conversation): align side borders of list items, increase icon size to match two-lines layout height Signed-off-by: Maksim Sukharev --- src/components/ConversationIcon.vue | 2 +- .../ConversationsList/Conversation.vue | 9 --------- .../ConversationsListVirtual.vue | 4 ++-- src/components/LeftSidebar/LeftSidebar.vue | 17 ++++++++++------- src/constants.js | 1 + 5 files changed, 14 insertions(+), 19 deletions(-) diff --git a/src/components/ConversationIcon.vue b/src/components/ConversationIcon.vue index bb60b41a829..e79a010db41 100644 --- a/src/components/ConversationIcon.vue +++ b/src/components/ConversationIcon.vue @@ -129,7 +129,7 @@ export default { size: { type: Number, - default: AVATAR.SIZE.DEFAULT, + default: AVATAR.SIZE.TWO_LINES, }, }, diff --git a/src/components/LeftSidebar/ConversationsList/Conversation.vue b/src/components/LeftSidebar/ConversationsList/Conversation.vue index 5bb46bfad1e..a2e43788ad8 100644 --- a/src/components/LeftSidebar/ConversationsList/Conversation.vue +++ b/src/components/LeftSidebar/ConversationsList/Conversation.vue @@ -329,15 +329,6 @@ export default { } .conversation { - // Overwrite NcListItem styles to reduce a component height - padding: 0 !important; - margin: var(--default-grid-baseline); - width: calc(100% - var(--default-grid-baseline) * 2); - - :deep(.list-item) { - padding-block: var(--default-grid-baseline); - } - // Overwrite ConversationIcon styles to blend a type icon with NcListItem & :deep(.list-item:hover .conversation-icon__type) { background-color: var(--color-background-hover); diff --git a/src/components/LeftSidebar/ConversationsList/ConversationsListVirtual.vue b/src/components/LeftSidebar/ConversationsList/ConversationsListVirtual.vue index c10aec4f8cc..c3c8f5c781a 100644 --- a/src/components/LeftSidebar/ConversationsList/ConversationsListVirtual.vue +++ b/src/components/LeftSidebar/ConversationsList/ConversationsListVirtual.vue @@ -29,9 +29,9 @@ import 'vue-virtual-scroller/dist/vue-virtual-scroller.css' /* Consider: * 48 = 2 * var(--default-line-height) - 2 lines of text * 8 = 2 * var(--default-grid-baseline) - item padding - * 4 = var(--default-grid-baseline) - item margin (collapsed) + * 8 = 2 * var(--default-grid-baseline) - focus offset */ -const CONVERSATION_ITEM_SIZE = 60 +const CONVERSATION_ITEM_SIZE = 64 export default { name: 'ConversationsListVirtual', diff --git a/src/components/LeftSidebar/LeftSidebar.vue b/src/components/LeftSidebar/LeftSidebar.vue index 9b403ec5a78..d368b9abc30 100644 --- a/src/components/LeftSidebar/LeftSidebar.vue +++ b/src/components/LeftSidebar/LeftSidebar.vue @@ -180,7 +180,7 @@ data-nav-id="conversation_create_new" @click="createConversation(searchText)">