Quota bypassed when uploading with chunked transfer encoding

[ylangisc]

When uploading a file with chunked transfer encoding (https://en.wikipedia.org/wiki/Chunked_transfer_encoding) the quota check is bypassed and you can upload as many bytes over the quota as you want .

Steps to reproduce

1. Create an account with a low quota
2. Upload a file that would hit the quota with chunked transfer encoding, i.e. using Mountain Duck which always use this kind of encoding
3. File is uploaded successfully

Expected behaviour

Server should reply with a 507 response

Actual behaviour

File can be uploaded

Server configuration

Operating system:
Ubuntu 16

Web server:
nginx 1.10.3

Database:
MariaDB

PHP version:
7.0

Nextcloud version: (see Nextcloud admin page)
12.0.4

Updated from an older Nextcloud/ownCloud or fresh install:
Fresh

Where did you install Nextcloud from:
Official download

Are you using external storage, if yes which one: local/smb/sftp/...
No

Are you using encryption: yes/no
No

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
No

[MorrisJobke]

cc @icewind1991 @danxuliu

[MorrisJobke]

@rullzer Mind to test this one?

[skjnldsv]

Still valid?

[ghost]

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

[dkocher]

Let us know what information is missing to reproduce.

[skjnldsv]

@dkocher you're still able to reproduce this issue on latest nextcloud stable ?

[ghost]

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

[dkocher]

@skjnldsv There is no reason to believe this has been fixed in a later version.

[dkocher]

@nextcloud-bot Please reopen this issue.

[dkocher]

@skjnldsv Auto closing reported bugs with steps to reproduce provided is not gentle and will discourage future bug reports.

[grote]

curl command for op step 2:

curl -H 'Transfer-Encoding: chunked' -H 'Content-Type: image/png' --compressed -v --user "$NEXTCLOUD_USER:$NEXTCLOUD_PASS" -T test.png 'https://cloud.myserver.de/remote.php/webdav/test.png

See that test.png get properly created and can be huge, bypassing quota check.

[grote]

Note that this problem my depend on the server configuration. Nextcloud on a Hetzner Storage Box seems to properly return a 507 error. Or this may have been fixed in a more recent version of Nextcloud.

[nextcloud-command]

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.